Add suspend mode for source breakpoints#610
Conversation
|
@tsmaeder I wrote a simple program to test it, but got error: public class HelloWorld {
public static void main(String[] args) {
System.out.println("Starting application...");
String message = "Hello, World!";
System.out.println(message); // Set a breakpoint here
for (int i = 0; i < 3; i++) {
System.out.println("Count: " + i);
}
System.out.println("Application finished.");
}
}Error: Also please fix CI errors. |
|
@chagong how are you testing? I have a very similar program which works fine for me. Also, this PR does not contain changes that could cause a problem with the delegate command handler, IMO. Here's what I do:
|
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
d6f08d7 to
b3e14c0
Compare
|
@tsmaeder probably the problem of my setup, it works after I relaunch vscode and F5. The PR is good to go after your fix the format errors. |
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
@chagong running checkstyle:check locally spews out messages about |
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
@chagong is there anything (beyond a rebase) that I could do to move this forward? |
|
Hi @tsmaeder, can you check if the fix to microsoft/vscode-java-debug#722 has already supported the suspend policy setting? |
|
@chagong no, this PR allows to set the suspend mode per breakpoint, the other PR just introduces a global flag. |
|
@tsmaeder we make it a global flag because vscode doesn't have UI option to set breakpoint property. Are you doing this for cursor? |

Fixes #608
Note that this PR contains code for handling source breakpoints and exception breakpoints. But in fact, VS Code Java only properly handles source and instruction breakpoints. I've left the code in there, since it's not completely trivial and it should not affect the behavior if no suspend mode is sent when setting the exception breakpoints.
How to Test