Handle replaceStart/replaceEnd in completion proposal#526
Open
mfussenegger wants to merge 2 commits intomicrosoft:mainfrom
Open
Handle replaceStart/replaceEnd in completion proposal#526mfussenegger wants to merge 2 commits intomicrosoft:mainfrom
mfussenegger wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Fixes build errors. The old location is no longer available: https://download.eclipse.org/releases/2023-12/202311171000/ returns 404
mfussenegger
changed the title
Fixes microsoft#524 Ensures completion text can be appended by clients E.g. For `com.|` the completion proposal has: completion: com.sun.jndi.ldap.pool completionLocation: 3 replaceEnd: 4 replaceStart: 0 `insertText` will be `sun.jndi.ldap.pool` For `List.|` the completion proposal has: completion: of() completionLocation: 4 replaceStart: 5 replaceEnd: 5 `insertText` will be `of()`
mfussenegger
force-pushed
the
completion-inserttext
branch
from
c343437 to
d5eb2db
Compare
Contributor
Author
|
Any chance to get some feedback on this? |
| $.setInsertText(insertText.substring(prefix)); | ||
| } else { | ||
| $.setInsertText(insertText); | ||
| } |
Contributor
There was a problem hiding this comment.
this doesn't work for VS Code. Typing Sys to trigger completion, select System and it becomes tem.
Jorgep77
approved these changes
Dec 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit is from #525
Second commit fixes #524
Ensures completion text can be appended by clients
E.g.
For
com.|the completion proposal has:insertTextwill besun.jndi.ldap.poolFor
List.|the completion proposal has:insertTextwill beof()I didn't find any existing completion tests, so not sure how to write a test case for this