Fix generic return type lambda breakpoint issue. Fix #1359#499
Merged
testforstephen merged 6 commits intomicrosoft:mainfrom Dec 12, 2023
Merged
Fix generic return type lambda breakpoint issue. Fix #1359#499testforstephen merged 6 commits intomicrosoft:mainfrom
testforstephen merged 6 commits intomicrosoft:mainfrom
Conversation
The fix tries to compare the runtime lambda method signature with none generic version of the method signature found from AST traversal as a additional comparison to what is there.
Contributor
Author
|
@testforstephen Let me know what you think about this change. This is vita when debugging reactive projects, specially when setting lambda breakpoints at Mono.flatMap operations. |
com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/Breakpoint.java
Show resolved
Hide resolved
This was
linked to
issues
Dec 5, 2023
Contributor
|
checkstyle failed. You can run it locally via |
testforstephen
approved these changes
Dec 12, 2023
Contributor
testforstephen
left a comment
testforstephen
left a comment
There was a problem hiding this comment.
LGTM. thanks for contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix tries to compare the runtime lambda method signature with none generic version of the method signature found from AST traversal as a additional comparison to what is there.