Repository navigation
Fix TestLCOW_IPv6_Assignment functional test - #2359
Merged
Kathryn Baldauf (katiewasnothere) merged 1 commit intoJan 30, 2025
Merged
Kathryn Baldauf (katiewasnothere) merged 1 commit into
Kathryn Baldauf (katiewasnothere) merged 1 commit into
Conversation
Kathryn Baldauf (katiewasnothere)
requested a review
from a team
as a code owner
January 22, 2025 21:56
Jie Chen (jiechen0826)
approved these changes
Jan 23, 2025
Jie Chen (jiechen0826)
left a comment
Jie Chen (jiechen0826)
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for fixing the test so quickly.
For additional context, before this fix, the test will fail because the IPv6 route has the scope ID (such as %24) attached to the end of NextHop. For example, given a route
ipv6Route := hcn.Route{
NextHop: "fd00::101",
DestinationPrefix: "::/0",
}
it becomes {NextHop:fd00::101%24 DestinationPrefix:::/0 Metric:0}] when accessing the route.
Hamza El-Saawy (helsaawy)
approved these changes
Jan 23, 2025
Contributor
|
The flaky tests were causing the CI to fail. |
Kathryn Baldauf (katiewasnothere)
force-pushed
the
user/kabaldau/lcow_ipv6_assignment_test
branch
from
January 28, 2025 22:34
ccb13b2 to
0638ee5
Compare
* Previously we were just using the IPAM routes configured earlier in the test, * but this causes an error since the IPAM route will append the scope identifier * at the end of IPv6 routes' NextHop. Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Kathryn Baldauf (katiewasnothere)
force-pushed
the
user/kabaldau/lcow_ipv6_assignment_test
branch
from
January 29, 2025 20:19
0638ee5 to
dbef1c1
Compare
Kathryn Baldauf (katiewasnothere)
deleted the
user/kabaldau/lcow_ipv6_assignment_test
branch
January 30, 2025 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were just using the IPAM routes configured earlier in the test, but this causes an error since the IPAM route will append the scope identifier at the end of IPv6 routes' NextHop.