Repository navigation
[release-branch.go1.26] Make telemetry default configurable through go.env - #2570
Merged
George Adams (gdams) merged 1 commit intoOct 14, 2026
Conversation
…o.env Backport #2566. The standalone telemetry guide does not exist on this release branch, so this backport contains only the Go patch update. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The backport faithfully applies the merged change and includes appropriate precedence and harness coverage.
0 open findings
What changed in this PR
Backports configurable Microsoft telemetry defaults to Go 1.26 while preserving standard Go environment precedence.
Changes:
- Adds the telemetry default to
GOROOT/go.env. - Resolves and exposes the setting through
go env. - Updates telemetry and script-harness tests.
| File | Description |
|---|---|
patches/0009-Add-appinsights-telemetry.patch |
Updates the release patch with configuration, documentation, and tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Quim Muntal (qmuntal)
approved these changes
Oct 14, 2026
George Adams (gdams)
merged commit Oct 14, 2026
0fd0ebb
into
microsoft/release-branch.go1.26
43 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #2566 to
microsoft/release-branch.go1.26.MS_GOTOOLCHAIN_TELEMETRY_ENABLED=1in the installation-wideGOROOT/go.envGOENVprecedencego envThis lets distributions change the installation default without patching the telemetry implementation. Users can still override that default through the process environment or
go env -w.The standalone
eng/doc/Telemetry.mdguide does not exist on this release branch, so this backport contains only the release's0009-Add-appinsights-telemetry.patchupdate.Validation
src/make.bashMS_GOTOOLCHAIN_TELEMETRY_ENABLED=0 go test cmd/go -run '^TestScript$/^(env_write|mod_permissions)$' -count=1go test cmd/internal/telemetry/counter -count=1go test -tags=cmd_go_bootstrap cmd/internal/telemetry/counter -count=1git go-patch extractsuccessfully reapplied the complete release patch stack