Add missing GC causes from gcCause.cpp#420
Merged
kcpeppe merged 1 commit intomicrosoft:mainfrom Mar 3, 2025
Merged
Conversation
1) Adding new GC causes from /src/jdk/src/hotspot/share/gc/shared/gcCause.cpp in JDK 21. This may help fix issues seen in microsoft#382. 2) Create GCCauses map programmatically from enum value list. This is less error prone in the event of adding causes.
j-bahr
force-pushed
the
add-gc-causes
branch
from
155e182 to
0fd71e2
Compare
j-bahr
commented
Feb 28, 2025
| // 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19 | ||
| { 4, 0, 2, 0, 0, 2, 0, 2, 2, 2, 0, 0, 2, 2, 0, 0, 0, 0, 2, 0}, | ||
| {1130, 141, 146, 0, 0, 146, 0, 146, 0, 146, 1, 0, 146, 146, 0, 0, 16, 146, 146, 0}, | ||
| {1130, 141, 146, 0, 1, 146, 0, 146, 0, 146, 0, 0, 146, 146, 0, 0, 16, 146, 146, 0}, |
Collaborator
Author
There was a problem hiding this comment.
These changes caught a bug in the G1 test, where the line
[226.179s][info ][gc,start ] GC(1198) Pause Full (Diagnostic Command)
Was not being identified correctly. Diagnostic Command was not in the GCCauses map and it was identified as a System.gc(). The fix now picks this up as Full GC type. The result is the the counts now differ after these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new GC causes from /src/jdk/src/hotspot/share/gc/shared/gcCause.cpp in JDK 21. This may help fix issues similar to what was seen in ZGC events GarbageCollectionType comes "Unknown" #380.
Create GCCauses map programmatically from enum value list. This is less error prone in the event of adding causes.