Merged
Conversation
This change allows us to detect a ZGC log when only using `-Xlog:gc`. The old tag required `gc+init=info`. This should improve log detection. Old detection using: ``` [info][gc,init] Initializing The Z Garbage Collector ``` New detection using: ``` [info][gc ] Using The Z Garbage Collector ```
Member
|
@kcpeppe I know you wanted to have a min set of logging flags that we would support - flagging this for your review |
Contributor
|
I like this change a lot. The more we can do with less info the better IMO. @karianna |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows us to detect a ZGC log when only using
-Xlog:gc. The old tag requiredgc+init=info. This should improve log detection. This should help fixes #382Old detection using:
New detection using: