Merged
Conversation
Minor fixes from feedback in microsoft#414 - Fix enum types to avoid having to throw IllegalArgumentException - Fix Memory summary to have more descriptive variable names - ZGCPhase now handles the regex null case correctly for Full (legacy) phase types - Use pause time to collect optional GC duration - Rename ZFwdRef -> ZForwardReference - Remove unused methods in ShenandoahParserTest.java
j-bahr
force-pushed
the
gen-zgc-fixes
branch
from
52c8068 to
4d24ab9
Compare
kcpeppe
reviewed
Mar 3, 2025
| } | ||
| } | ||
| throw new IllegalArgumentException("No matching ZGCCollectionType found for: " + label); | ||
| return Arrays.stream(ZGCCollectionType.class.getEnumConstants()) |
Contributor
There was a problem hiding this comment.
I'll accept this but... what do you think about introducing "Unknown" and return that instead of returning null?
kcpeppe
reviewed
Mar 3, 2025
| return Arrays.stream(ZGCPhase.class.getEnumConstants()) | ||
| .filter(phase -> Objects.equals(phase.getPhase(), label)) | ||
| .findFirst() | ||
| .orElse(null); |
Contributor
There was a problem hiding this comment.
same as previous comment about Unknown
Merged
This was referenced Feb 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes from feedback in #414