Fix for gctoolkit #352 (Generational Heap Parser fails to recognize parallel gc lines)#362
Merged
karianna merged 2 commits intomicrosoft:mainfrom Jun 23, 2024
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="PTC" |
dsgrieve
approved these changes
Jun 20, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was caused by mismatched indices in the regex that matches a Parallel collection. The indices of two methods (YoungGen and Failure) in GenerationalHeapParser have been updated to correctly match the expected index so that the lines no longer generate a "not implemented" error in debug mode.
I also reviewed the test suite to determine why this issue wasn't caught, and found that there was no test case that explicitly tested the parsing of Parallel GC lines, so I've added an additional test case for PSYoungGen that fails before the changes, and passes afterwards.
I was unable to add a similar test case for Failure using the current strategy of parse and check for events as the failure line appears to be ignored.
There is a chance that further fixes are required for less-frequently logged lines, but for any sample data I have available, the files now parse successfully.