Estimate the start time by variance#360
Merged
kcpeppe merged 3 commits intomicrosoft:mainfrom Jun 24, 2024
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
kcpeppe
approved these changes
Jun 10, 2024
Member
Contributor
Author
dsgrieve
approved these changes
Jun 20, 2024
karianna
requested changes
Jun 23, 2024
| } | ||
|
|
||
| @Aggregates({EventSource.CMS_PREUNIFIED,EventSource.CMS_UNIFIED,EventSource.G1GC,EventSource.GENERATIONAL,EventSource.JVM,EventSource.SHENANDOAH, EventSource.TENURED,EventSource.ZGC}) | ||
| @Aggregates({EventSource.GENERATIONAL,EventSource.CMS_UNIFIED,EventSource.G1GC,EventSource.GENERATIONAL,EventSource.JVM,EventSource.SHENANDOAH, EventSource.TENURED,EventSource.ZGC}) |
Member
There was a problem hiding this comment.
This does seem incorrect? It's a duplicate?
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for fixing #257
Below is a summary of the changes made in this pull request:
OnlineCalculatorclasses -WelfordVarianceCalculatorandOnlineStatisticsCalculatorOnlineCalculatorclassesRegarding the estimated start time, I used a slightly different approach than suggested in #257
timeOfFirstEventdoes not have time stamp, the method will returndate stamp - SD of GC frequencytimeOfFirstEventhas time stamptime stamp - SD of GC frequencytimeOfFirstEvent, since we cannot have negative time stampPlease review the code and provide any comments or feedback you may have. I would also appreciate clarification on the specific points mentioned above!