Use released packages in on-demand sandbox sample#750
Closed
YunchuWang wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the on-demand sandbox sample to consume released Azure Managed Durable Task Scheduler NuGet packages (instead of source project references), and streamlines the remote worker container build to only include the sample tree and restore from packages—making the sample easier to use outside of the repo.
Changes:
- Switch main-app and remote-worker samples from
ProjectReferencetoPackageReferencefor Azure Managed (and related sandbox) packages at1.25.0-preview.2. - Remove the unnecessary
Microsoft.DurableTask.Worker.AzureManaged.Sandboxesdependency from the main-app sample. - Update the remote-worker Containerfile to copy only required build inputs and disable signing during publish.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| samples/on-demand-sandbox/remote-worker/remote-worker.csproj | Replaces SDK project references with released Azure Managed worker package references. |
| samples/on-demand-sandbox/remote-worker/Containerfile | Builds the worker image from only sample sources + NuGet restore, avoiding copying the full repo. |
| samples/on-demand-sandbox/main-app/main-app.csproj | Moves the main app to released client/worker packages and generator analyzer package; removes unneeded worker sandbox dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.25.0-preview.2Azure Managed packages instead of SDK project references.Microsoft.DurableTask.Worker.AzureManaged.Sandboxesdependency from the main app sample.Validation
dotnet build .\samples\on-demand-sandbox\main-app\main-app.csprojdotnet build .\samples\on-demand-sandbox\remote-worker\remote-worker.csprojwbdtspoc76f6bd.azurecr.io/dts-ondemand-sandbox-dotnet-sample:releasedpkg-20260617153611wbserverless34san / ondemandsandbox; orchestration89b9255469f24e3a8ff04e79bb356e5ecompleted and executed the remote activity in ADC sandbox.