feat: in verbose mode have mock print all output#231
Merged
dmcilvaney merged 2 commits intoJul 7, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the mock runner to make verbose mode stream much more of mock’s output directly to the console, and adjusts the long-running UX so progress spinners don’t interfere with live output.
Changes:
- Add
--verboseto mock invocations whenctx.Verbose()is enabled (and keep--quietfor non-verbose runs). - Skip the indeterminate “Waiting for mock…” spinner during RPM builds when running in verbose mode.
Comment on lines
+651
to
656
| if r.verbose { | ||
| // Have mock stream its full build output (including build.log) live to the console. | ||
| args = append(args, "--verbose") | ||
| } else { | ||
| args = append(args, "--quiet") | ||
| } |
Comment on lines
+651
to
656
| if r.verbose { | ||
| // Have mock stream its full build output (including build.log) live to the console. | ||
| args = append(args, "--verbose") | ||
| } else { | ||
| args = append(args, "--quiet") | ||
| } |
reubeno
reviewed
Jun 8, 2026
| // In verbose mode, mock streams its full build output to the console, so we skip the | ||
| // indeterminate progress spinner (which would otherwise fight with the live output). | ||
| if !r.verbose { | ||
| extcmd = extcmd.SetLongRunning("Waiting for mock (building RPM)...") |
Member
There was a problem hiding this comment.
Would it be cleaner to change what .SetLongRunning() does in verbose mode?
reubeno
added
the
state: needs submitter action
Contributor
There was a problem hiding this comment.
⚠️ Not ready to approve
There is a misleading error message in Runner.InitRoot that reports an SRPM build failure instead of a root initialization failure.
Copilot's findings
Comments suppressed due to low confidence (1)
internal/rpm/mock/mock.go:249
- In InitRoot, the error message on failure still says "mock failed to build SRPM", which is misleading for callers troubleshooting root initialization failures. Please update the message to reflect that this is the root init path.
extcmd.SetLongRunning("Waiting for mock (initializing build root)...")
err = extcmd.Run(ctx)
if err != nil {
return fmt.Errorf("mock failed to build SRPM:\n%w", err)
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
Tonisal-byte
approved these changes
Jul 6, 2026
dmcilvaney
force-pushed
the
damcilva/super_verbose_mock
branch
from
48b97d2 to
be84a11
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
internal/rpm/mock/mock.go:249
InitRootreturns an error message that says mock “failed to build SRPM”, which is misleading for a root initialization failure. This makes troubleshooting harder whenmock --initfails.
extcmd.SetLongRunning("Waiting for mock (initializing build root)...")
err = extcmd.Run(ctx)
if err != nil {
return fmt.Errorf("mock failed to build SRPM:\n%w", err)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is VERY verbose, but it is very useful for tracking progress in pipelines etc.