Add .NET 8/9/10 target frameworks to fix BinaryFormatter crash in GViewer by Copilot · Pull Request #396 · microsoft/automatic-graph-layout

Copilot · 2026-06-03T22:52:39Z

GViewer() crashes on .NET 9+ with PlatformNotSupportedException because GViewer.resx embeds an ImageListStreamer as application/x-microsoft.net.object.binary.base64 — a format requiring BinaryFormatter, which was completely removed in .NET 9.

Windows Forms in .NET 9+ reimplemented ImageListStreamer deserialization without BinaryFormatter. The fix is to ship dedicated TFM binaries so .NET 9/10 consumers get the runtime that handles this natively.

Core library (`GraphViewerGDI`)

Extend TargetFrameworks: net472;net6.0-windows → net472;net6.0-windows;net8.0-windows;net9.0-windows;net10.0-windows
Add <GenerateResourceUsePreserializedResources>true</GenerateResourceUsePreserializedResources> — required by the .NET 10 SDK for projects with binary .resx resources targeting net472
Update GraphViewerGDI.nuspec with dependencies and <files> entries for the three new TFMs

Downstream projects

Add net8.0-windows, net9.0-windows, net10.0-windows TFMs to:

Tools: FormForGViewer, DebugCurveViewer, agl, WpfGraphControl, GraphmapsWpfControl
Tests: TestFormForGViewer, TestForGDI, Test01, VoronoiDiagramTest, TestGraphmaps
Samples: all 23 sample projects targeting net472;net6.0-windows or net6.0-windows
WriteToSvgSample / SvgLayerSample (non-Windows): extend with net8.0, net9.0, net10.0

…works - GraphViewerGDI: add net8.0-windows, net9.0-windows, net10.0-windows TFMs - GraphViewerGDI: add GenerateResourceUsePreserializedResources=true for net472 fix - GraphViewerGDI.nuspec: add NuGet entries for new TFMs - All tool, test, and sample projects: add net8/9/10-windows TFMs

Restore lines clobbered while adding net8/9/10 TFMs: - RootNamespace in TestForGDI, Test01, DebugCurveViewer, FormForGViewer - UseWPF in WpfGraphControl, GraphmapsWpfControl - UseWindowsForms/WarningLevel in agl Fixes invalid XML (MSB4025) and broken WPF builds so all projects build on net9/net10 while keeping the BinaryFormatter crash fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

snechaev · 2026-06-04T14:29:55Z

+      <group targetFramework="net8.0-windows7.0">
+        <frameworkReference name="Microsoft.WindowsDesktop.App.WinForms" />
+      </group>
+      <group targetFramework="net9.0-windows7.0">
+        <frameworkReference name="Microsoft.WindowsDesktop.App.WinForms" />
+      </group>
+      <group targetFramework="net10.0-windows7.0">
+        <frameworkReference name="Microsoft.WindowsDesktop.App.WinForms" />
+      </group>


@copilot, most likely this not needed. Adding this for modern Target Frameworks (like net9, net10) will (most likely) cause #390.

snechaev · 2026-06-04T14:33:20Z

@copilot, consider to review and update WpfGraphControl.nuspec to include the build artifacts for the newly added TFMs in the WPF-specific package. Beware of #390.

…n-dotnet-9

GraphViewerGDI.nuspec: remove frameworkReference entries for net8/9/10 (only net6 kept); adding Microsoft.WindowsDesktop.App.WinForms for modern TFMs triggers issue #390 (NETSDK1073). WpfGraphControl.nuspec: add dependency groups and lib file entries for net8/9/10-windows so the WPF package ships the new TFM build artifacts, without adding frameworkReference entries (beware of issue #390). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR expands the target frameworks across MSAGL’s WinForms/WPF viewer components, tools, tests, and samples to produce dedicated net8.0*, net9.0*, and net10.0* binaries so that .NET 9+ consumers avoid the BinaryFormatter-based ImageListStreamer .resx deserialization crash, and updates NuGet packaging accordingly.

Changes:

Multi-targets Windows desktop projects with net8.0-windows, net9.0-windows, net10.0-windows (in addition to existing net472/net6.0-windows).
Updates GraphViewerGDI build settings for binary .resx resources via GenerateResourceUsePreserializedResources=true.
Extends .nuspec dependency groups and lib/ assets to ship assemblies for the new TFMs.

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
GraphLayout/WriteToSvgSample/WriteToSvgSample.csproj	Adds `net8.0;net9.0;net10.0` multi-targeting for the non-Windows SVG sample.
GraphLayout/tools/WpfGraphControl/WpfGraphControl.nuspec	Adds dependency groups and `lib/` entries for `net8/9/10` assets.
GraphLayout/tools/WpfGraphControl/WpfGraphControl.csproj	Adds `net8/9/10-windows` TFMs to build WPF control binaries for newer runtimes.
GraphLayout/tools/GraphViewerGDI/GraphViewerGDI.nuspec	Adds dependency groups and `lib/` entries for `net8/9/10` assets.
GraphLayout/tools/GraphViewerGDI/GraphViewerGDI.csproj	Adds `net8/9/10-windows` TFMs and enables preserialized resources for binary `.resx`.
GraphLayout/tools/GraphmapsWpfControl/GraphmapsWpfControl.csproj	Adds `net8/9/10-windows` TFMs for downstream WPF control.
GraphLayout/tools/FormForGViewer/FormForGViewer.csproj	Adds `net8/9/10-windows` TFMs for downstream tool/library.
GraphLayout/tools/DebugCurveViewer/DebugCurveViewer.csproj	Adds `net8/9/10-windows` TFMs for downstream tool.
GraphLayout/tools/agl/agl.csproj	Adds `net8/9/10-windows` TFMs for downstream tool.
GraphLayout/TinyClickDemo/TinyClickDemo.csproj	Adds `net8/9/10-windows` TFMs for a demo app.
GraphLayout/Test/VoronoiDiagramTest/VoronoiDiagramTest.csproj	Adds `net8/9/10-windows` TFMs for test app.
GraphLayout/Test/TestGraphmaps/TestGraphmaps.csproj	Extends existing test multi-targeting to include `net9/10-windows`.
GraphLayout/Test/TestFormForGViewer/TestFormForGViewer.csproj	Adds `net8/9/10-windows` TFMs for test project.
GraphLayout/Test/TestForGDI/TestForGDI.csproj	Adds `net8/9/10-windows` TFMs for test app.
GraphLayout/Test/Test01/Test01.csproj	Adds `net8/9/10-windows` TFMs for test app.
GraphLayout/Samples/WpfApplicationSample/WpfApplicationSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/WpfApplicationSample_OnnxViewer/WpfApplicationSample_OnnxViewer.csproj	Converts single target to multi-target including `net8/9/10-windows`.
GraphLayout/Samples/WindowsApplicationSample/WindowsApplicationSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/UsingMDSLayoutSample/UsingMDSLayoutSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/SvgLayerSample/SvgLayerSample.csproj	Adds `net8.0;net9.0;net10.0` multi-targeting for the non-Windows SVG sample.
GraphLayout/Samples/SimplestWinFormsSample/SimplestWinFormsSample.csproj	Adds `net8/9/10-windows` TFMs for WinForms sample.
GraphLayout/Samples/SameLayerSample/SameLayerSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/PopulateGViewerWithPrecalculatedDrawingGraph/PopulateGViewerWithPrecalculatedDrawingGraph.csproj	Adds `net8/9/10-windows` TFMs for WinForms sample.
GraphLayout/Samples/PhyloTreeSampleOverGDI/PhyloTreeSampleOverGDI.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/PhyloTreeFromGeometrySample/PhyloTreeFromGeometrySample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/NodesWithImages/NodesWithImages.csproj	Adds `net8/9/10-windows` TFMs for WinForms sample.
GraphLayout/Samples/MinWpfApp/MinWpfApp.csproj	Adds `net8/9/10-windows` TFMs for WPF sample.
GraphLayout/Samples/LocationLabeling/LocationLabeler.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/LoadingDgmlGraph/LoadingDgmlGraph.csproj	Adds `net8/9/10-windows` TFMs for WinForms sample.
GraphLayout/Samples/LayoutOfADisconnectedGraphWithSugiyama/LayoutOfADisconnectedGraphWithSugiyama.csproj	Adds `net8/9/10-windows` TFMs for WinForms sample.
GraphLayout/Samples/LayerConstraintsFromGeometrySample/LayerConstraintsFromGeometrySample.csproj	Adds `net8/9/10-windows` TFMs for WinForms sample.
GraphLayout/Samples/GeometryRoutinesSample/GeometryRoutinesSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/FindEmptySpotSample/FindEmptySpotSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/FastIncrementalLayoutWithGdi/FastIncrementalLayoutWithGdi.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/Editing/Editing.csproj	Adds `net8/9/10-windows` TFMs for WinForms sample.
GraphLayout/Samples/EdgeRoutingSample/EdgeRoutingSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/EdgeDirectionTest/EdgeDirectionTest.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/DrawingFromGeometryGraphSample/DrawingFromGeometryGraphSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.
GraphLayout/Samples/AspectRatioSample/SettingGraphBoundsSample.csproj	Adds `net8/9/10-windows` TFMs for sample app.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+      <group targetFramework="net8.0-windows7.0">
+        <dependency id="Msagl.Drawing" version="BuildVersion" />
+      </group>
+      <group targetFramework="net9.0-windows7.0">
+        <dependency id="Msagl.Drawing" version="BuildVersion" />
+      </group>
+      <group targetFramework="net10.0-windows7.0">
+        <dependency id="Msagl.Drawing" version="BuildVersion" />
+      </group>


+      <group targetFramework="net8.0-windows7.0">
+        <dependency id="Msagl.Drawing" version="BuildVersion" />
+      </group>
+      <group targetFramework="net9.0-windows7.0">
+        <dependency id="Msagl.Drawing" version="BuildVersion" />
+      </group>
+      <group targetFramework="net10.0-windows7.0">
+        <dependency id="Msagl.Drawing" version="BuildVersion" />
+      </group>


Initial plan

ce59c0d

Copilot AI assigned Copilot and levnach Jun 3, 2026

Copilot started work on behalf of levnach June 3, 2026 22:52 View session

Copilot AI linked an issue Jun 3, 2026 that may be closed by this pull request

Crash in .Net 9 due to missing BinaryFormatter #387

Open

Copilot AI changed the title ~~[WIP] Fix crash in .NET 9 due to missing BinaryFormatter~~ Add .NET 8/9/10 target frameworks to fix BinaryFormatter crash in GViewer Jun 3, 2026

Copilot finished work on behalf of levnach June 3, 2026 23:07

Copilot AI requested a review from levnach June 3, 2026 23:07

snechaev reviewed Jun 4, 2026

View reviewed changes

levnach approved these changes Jun 4, 2026

View reviewed changes

Copilot CLI and others added 2 commits June 4, 2026 09:44

Merge remote-tracking branch 'origin/master' into copilot/fix-crash-i…

50f1f8c

…n-dotnet-9

levnach marked this pull request as ready for review June 4, 2026 16:53

levnach requested review from Copilot and levnach June 4, 2026 16:55

Copilot started reviewing on behalf of levnach June 4, 2026 16:56 View session

levnach approved these changes Jun 4, 2026

View reviewed changes

Copilot AI reviewed Jun 4, 2026

View reviewed changes

levnach requested a review from NikolajBjorner June 4, 2026 17:01

NikolajBjorner approved these changes Jun 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add .NET 8/9/10 target frameworks to fix BinaryFormatter crash in GViewer#396

Add .NET 8/9/10 target frameworks to fix BinaryFormatter crash in GViewer#396
Copilot wants to merge 5 commits into
masterfrom
copilot/fix-crash-in-dotnet-9

Copilot AI commented Jun 3, 2026 •

edited

Loading

Uh oh!

snechaev Jun 4, 2026

Uh oh!

snechaev commented Jun 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core library (GraphViewerGDI)

Downstream projects

Uh oh!

snechaev Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

snechaev commented Jun 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Jun 3, 2026 •

edited

Loading

Core library (`GraphViewerGDI`)