Only add double-dash to args if there are previous app-host-added args - #7769
Merged
David Fowler (davidfowl) merged 7 commits intoMar 1, 2025
Conversation
Adam Ratzman (adamint)
requested review from
James Newton-King (JamesNK),
Copilot and
Mitch Denny (mitchdenny)
February 25, 2025 16:30
added 4 commits
February 25, 2025 14:01
…gs-when-no-apphost-args
…dash" This reverts commit d128b27.
Member
|
Correct. They should be unncessary. |
Mitch Denny (mitchdenny)
approved these changes
Feb 25, 2025
Mitch Denny (mitchdenny)
left a comment
Member
There was a problem hiding this comment.
Why not just do the check internally to the method.
Mitch Denny (mitchdenny)
approved these changes
Feb 25, 2025
Member
|
Please do some testing with this in the playground just to make sure there are no rough edges here. |
Member
|
Even if there are previous app host added args, the double dash could be excluded from what is displayed to the user by not adding it to the custom annotation. This is a suggested improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It doesn't appear that a double-dash is required to be prepended to application launch args when there are no app host arguments. Mitch Denny (@mitchdenny) does this make sense?
Fixes #7751
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):