Skip to content

Only add double-dash to args if there are previous app-host-added args - #7769

Merged
David Fowler (davidfowl) merged 7 commits into
microsoft:mainfrom
adamint:dev/adamint/remove-double-dash-executable-args-when-no-apphost-args
Mar 1, 2025
Merged

David Fowler (davidfowl) merged 7 commits into
microsoft:mainfrom
adamint:dev/adamint/remove-double-dash-executable-args-when-no-apphost-args

Conversation

@adamint

Copy link
Copy Markdown
Member

Description

It doesn't appear that a double-dash is required to be prepended to application launch args when there are no app host arguments. Mitch Denny (@mitchdenny) does this make sense?

Fixes #7751

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@mitchdenny

Copy link
Copy Markdown
Member

Correct. They should be unncessary.

@mitchdenny Mitch Denny (mitchdenny) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just do the check internally to the method.

@mitchdenny

Copy link
Copy Markdown
Member

Please do some testing with this in the playground just to make sure there are no rough edges here.

@JamesNK

James Newton-King (JamesNK) commented Feb 26, 2025 •

Copy link
Copy Markdown
Member

Even if there are previous app host added args, the double dash could be excluded from what is displayed to the user by not adding it to the custom annotation.

This is a suggested improvement.

@davidfowl
David Fowler (davidfowl) merged commit 0e6c1a8 into microsoft:main Mar 1, 2025
@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire] An extra dash is displayed in --port for functionapp when running an Aspire 9.2 project with Azure Functions.

5 participants