Skip to content

Support resource restart in ResourceHealthCheckService#7238

Merged
davidfowl merged 2 commits into
mainfrom
jamesnk/resourcereadyevent-restart
Jan 25, 2025
Merged

Support resource restart in ResourceHealthCheckService#7238
davidfowl merged 2 commits into
mainfrom
jamesnk/resourcereadyevent-restart

Conversation

@JamesNK

@JamesNK JamesNK commented Jan 24, 2025

Copy link
Copy Markdown
Member

Description

Changes:

  • Health checks are stopped when the resource is in a terminal state, e.g. exited, finished.
  • Health checks can be restarted after stopped.
  • ResourceReadyEvent is now fired the first time a resource becomes ready after starting. That means restarting a resource and it becoming healthy again causes ResourceReadyEvent to fire again.

Fixes #6385
Fixes #6450
Fixes #7011

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK requested a review from mitchdenny as a code owner January 24, 2025 17:55
@JamesNK JamesNK requested review from davidfowl and eerhardt January 24, 2025 17:55
@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 24, 2025
@JamesNK JamesNK force-pushed the jamesnk/resourcereadyevent-restart branch from 77ddde7 to fc999c6 Compare January 24, 2025 17:57
Comment thread src/Aspire.Hosting/Health/ResourceHealthCheckService.cs Outdated
Comment thread src/Aspire.Hosting/Health/ResourceHealthCheckService.cs Outdated
@davidfowl davidfowl merged commit 4bf3231 into main Jan 25, 2025
@davidfowl davidfowl deleted the jamesnk/resourcereadyevent-restart branch January 25, 2025 01:58
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

2 participants