[release/9.0] Set docker summaries for all extensions.#6433
Merged
Conversation
Saw that it was missing on SqlServer during Damian's demo.
eerhardt
approved these changes
Oct 22, 2024
16 tasks
davidfowl
approved these changes
Oct 22, 2024
Member
|
Is this going to work with a lot of these tags classes being internal? |
Contributor
I tried from the playground project on Oracle, and AFAIK there is no InternalVisitbleTo on this one (see screenshot below) And we can still see the docs. I will test with the packages though. |
Contributor
|
Verified with locally built packages: And the .nupkg contains the xml docs file which seems to embed even the internal values (at least for the inherited ones) <doc>
<assembly>
<name>Aspire.Hosting.Oracle</name>
</assembly>
<members>
<member name="F:Aspire.Hosting.OracleContainerImageTags.Registry">
<remarks>container-registry.oracle.com</remarks>
</member>
<member name="F:Aspire.Hosting.OracleContainerImageTags.Image">
<remarks>database/free</remarks>
</member>
<member name="F:Aspire.Hosting.OracleContainerImageTags.Tag">
<remarks>23.5.0.0</remarks>
</member>
<member name="T:Aspire.Hosting.OracleDatabaseBuilderExtensions">
<summary>
Provides extension methods for adding Oracle Database resources to an <see cref="T:Aspire.Hosting.IDistributedApplicationBuilder"/>.
</summary>
</member>
<member name="M:Aspire.Hosting.OracleDatabaseBuilderExtensions.AddOracle(Aspire.Hosting.IDistributedApplicationBuilder,System.String,Aspire.Hosting.ApplicationModel.IResourceBuilder{Aspire.Hosting.ApplicationModel.ParameterResource},System.Nullable{System.Int32})">
<summary>
Adds a Oracle Server resource to the application model. A container is used for local development.
</summary>
<remarks>
This version of the package defaults to the <inheritdoc cref="F:Aspire.Hosting.OracleContainerImageTags.Tag"/> tag of the <inheritdoc cref="F:Aspire.Hosting.OracleContainerImageTags.Registry"/>/<inheritdoc cref="F:Aspire.Hosting.OracleContainerImageTags.Image"/> container image. |
Member
|
Low Risk (only changing comments), great value add for customers. Approved. |
joperezr
added a commit
to joperezr/aspire
that referenced
this pull request
Nov 13, 2024
#### AI description (iteration 1) #### PR Classification Merge branch `release/9.0` into `internal/release/9.0` to integrate recent changes and address specific work items. #### PR Summary This pull request integrates changes from the `release/9.0` branch into `internal/release/9.0`, addressing several work items related to Azure storage and network isolation. - `/tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs`: Added a new test `ConfigureCustomDomainsMutatesIngress` to validate custom domain configuration for Azure Container Apps. - `/src/Aspire.Hosting.Azure.AppContainers/ContainerAppExtensions.cs`: Introduced a new extension method `ConfigureCustomDomain` to simplify the process of assigning custom domains to Azure Container Apps. Related work items: microsoft#6368, microsoft#6391, microsoft#6433, microsoft#6458, microsoft#6467
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Backport of #6323 to release/9.0
/cc @sebastienros
Customer Impact
Code documentation improvements.
Testing
Validated the tooltip shows the container image information:
Risk
None.
Regression?
No.
Microsoft Reviewers: Open in CodeFlow