Skip to content

Suppress gRPC resource service error in host console#5534

Merged
JamesNK merged 2 commits into
mainfrom
jamesnk/resource-service-error
Sep 4, 2024
Merged

Suppress gRPC resource service error in host console#5534
JamesNK merged 2 commits into
mainfrom
jamesnk/resource-service-error

Conversation

@JamesNK

@JamesNK JamesNK commented Sep 4, 2024

Copy link
Copy Markdown
Member

Description

The host could display transient gRPC service errors caused by the dashboard quickly starting and stopping streaming methods.

This PR:

  • Increases log level of gRPC server logging to error.
  • Adds explicit error logging to the resource service so non-transient errors are always reported.

Fixes #4213

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 4, 2024
@JamesNK JamesNK merged commit b9bd67c into main Sep 4, 2024
@JamesNK JamesNK deleted the jamesnk/resource-service-error branch September 4, 2024 06:37
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AzureTools][Aspire] An error occurs in the command prompt when clicking "Console" tab in the left again or more times

2 participants