Show OLTP timestamps using user's time format preferences#2135
Merged
Conversation
We want to show timestamps with millisecond-level precision, however there's no built-in format string for that that respects the user's preferences. Microsoft docs provided the approach taken here, which uses the user's default pattern (which comes from the machines culture and may be overridden by the user at the system level), and modifies it to append milliseconds after the seconds. It respects the user's preference for decimal separators too.
drewnoakes
added
the
area-telemetry
JamesNK
approved these changes
Feb 8, 2024
JamesNK
reviewed
Feb 8, 2024
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 12, 2024
…2135) We want to show timestamps with millisecond-level precision, however there's no built-in format string for that that respects the user's preferences. Microsoft docs provided the approach taken here, which uses the user's default pattern (which comes from the machines culture and may be overridden by the user at the system level), and modifies it to append milliseconds after the seconds. It respects the user's preference for decimal separators too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1551
We want to show certain timestamps with millisecond-level precision, however there's no built-in format that respects the user's time formatting preferences while also showing milliseconds. Microsoft docs provided the approach taken here, which uses the user's default pattern (which comes from the machines culture and may be overridden by the user at the system level), and modifies it to append milliseconds after the seconds. It respects the user's preference for decimal separators too.
Resources view
Structured logs
Traces
Microsoft Reviewers: Open in CodeFlow