Skip to content

Disable App Configuration provisioning deployment test - #20818

Merged
Mitch Denny (mitchdenny) merged 1 commit into
mainfrom
mitchdenny-disable-app-configuration-test
Oct 12, 2026
Merged

Mitch Denny (mitchdenny) merged 1 commit into
mainfrom
mitchdenny-disable-app-configuration-test

Conversation

@mitchdenny

Copy link
Copy Markdown
Member

Description

Disable only Aspire.Deployment.EndToEnd.Tests.TypeScriptAzureProvisioningDeploymentTests.DeployAppConfigurationWithProvisioningOverrides with [ActiveIssue("https://github.com/microsoft/aspire/issues/20815")] using QuarantineTools. Keep DeployNetworkAndPrivateDnsWithProvisioningOverrides enabled and unchanged.

The infrastructure-only AppHost adds an App Configuration store with default role assignments but no application principal or identity-capable compute environment. BicepProvisioner intentionally rejects the unbound principal. The scenario has failed since its introduction in #20131; no passing execution has been established. This is not a subscription-cutover regression. Product logic, test logic, and the existing AzureDeployerTests no-environment failure contract remain unchanged. Re-enable this scenario once its AppHost setup is corrected.

Addresses #20815. This PR intentionally leaves the issue open. No new dependencies.

Validation

  • ./restore.sh — passed.
  • ./dotnet.sh run --project tools/QuarantineTools -- -q -m activeissue -i https://github.com/microsoft/aspire/issues/20815 Aspire.Deployment.EndToEnd.Tests.TypeScriptAzureProvisioningDeploymentTests.DeployAppConfigurationWithProvisioningOverrides — passed; updated only the requested method's attribute.
  • ./dotnet.sh build tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj — passed, zero warnings/errors.
  • ./dotnet.sh test --project tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj --no-launch-profile -- --list-tests --filter-class '*.TypeScriptAzureProvisioningDeploymentTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' — initial discovery command failed with SDK handshake exit 12 because --list-tests must precede --; corrected below.
  • ./dotnet.sh test --project tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj --no-build --no-launch-profile --list-tests -- --filter-class '*.TypeScriptAzureProvisioningDeploymentTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' — passed; exactly one test discovered: DeployNetworkAndPrivateDnsWithProvisioningOverrides. Disabled App Configuration scenario absent.
  • ./dotnet.sh test --project tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj --no-build --no-launch-profile -- --filter-method '*.DeployAppConfigurationWithProvisioningOverrides' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' — expected zero tests ran, MTP exit 8; confirms disabled target cannot execute.
  • git diff --check — passed.

Audited deployment routing: deployment-tests.yml uses nightly schedule and manual dispatch (including the PR deployment command), with class-scoped selection and OnlyDeploymentTests=true. The standard test enumeration excludes this project. test-trigger-map.yml already classifies deployment paths and runtime production dependencies as dedicated schedule/dispatch-only job:deployment-e2e inputs. No regular-PR consumer is being removed, and no routing changes are needed. The class retains its enabled companion scenario.

No live Azure deployment or mutation was performed; companion deployment execution was not rerun locally.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Disabled: DeployAppConfigurationWithProvisioningOverrides
Issue: #20815

The infrastructure-only AppHost has no application principal for its default role assignments. Keep the companion network/private-DNS test enabled.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20818

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20818"

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Tests selector

0 / 98 PR test projects · 0 PR jobs, from 1 changed file.

Selected PR test projects (0 / 98)

none — no PR-gated .NET test projects run for this change.

Selected PR jobs (0)

none


How these were chosen — grouped by what changed

Job reasons

none


Selection computed for commit 25c3915.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted test is correctly disabled without affecting the enabled companion scenario or CI routing.

0 open findings

What changed in this PR

Disables the deterministically failing App Configuration deployment test while retaining its tracking issue and companion scenario.

Changes:

  • Adds ActiveIssue for issue #20815 to the affected test only.
File Description
tests/​Aspire.Deployment.EndToEnd.Tests/​TypeScriptAzureProvisioningDeploymentTests.cs Disables the failing App Configuration scenario.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@mitchdenny
Mitch Denny (mitchdenny) merged commit 39bf0fb into main Oct 12, 2026
57 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Oct 12, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Step 5 branch taken: docs_required → proven false positive, no actual user-facing change (per Step 10's explicit allowance to override docs_required when the signal is a proven false positive).

Triggered signals (1): pr_body_has_cli_flag_mention. Evidence quoted in signals.json: - \./dotnet.sh run --project tools/QuarantineTools -- -q -m activeissue -i (githu/redacted)`. This is a line from the PR's internal **Validation** section showing how the author invoked the repo-internal QuarantineToolsdev utility to apply an[ActiveIssue]attribute — not a mention of a product/user-facing CLI flag.-q, -m, -i, --projecthere aredotnet`/QuarantineTools developer-tooling switches, never exposed to end users and not part of any documented product surface on microsoft/aspire.dev.

Why no docs are needed: The PR's only code change is tests/Aspire.Deployment.EndToEnd.Tests/TypeScriptAzureProvisioningDeploymentTests.cs (+1/-0), adding [ActiveIssue("https://github.com/microsoft/aspire/issues/20815")] to quarantine one flaky/broken deployment E2E test method (DeployAppConfigurationWithProvisioningOverrides) while leaving its sibling test and all product/test logic untouched. signals.json also records only_test_or_build_changes: true and changed_file_count: 1, confirming this is a pure test-infrastructure change with zero impact on any documented product behavior, CLI, API, or configuration surface. There is nothing new or changed for a docs reader to learn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants