Repository navigation
Disable App Configuration provisioning deployment test - #20818
Conversation
Disabled: DeployAppConfigurationWithProvisioningOverrides Issue: #20815 The infrastructure-only AppHost has no application principal for its default role assignments. Keep the companion network/private-DNS test enabled. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20818Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20818" |
Tests selector0 / 98 PR test projects · 0 PR jobs, from 1 changed file. Selected PR test projects (0 / 98)none — no PR-gated .NET test projects run for this change. Selected PR jobs (0)none How these were chosen — grouped by what changedJob reasonsnone Selection computed for commit |
There was a problem hiding this comment.
🟢 Approval recommended
The targeted test is correctly disabled without affecting the enabled companion scenario or CI routing.
0 open findings
What changed in this PR
Disables the deterministically failing App Configuration deployment test while retaining its tracking issue and companion scenario.
Changes:
- Adds
ActiveIssuefor issue #20815 to the affected test only.
| File | Description |
|---|---|
tests/Aspire.Deployment.EndToEnd.Tests/TypeScriptAzureProvisioningDeploymentTests.cs |
Disables the failing App Configuration scenario. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
|
✅ No documentation update needed. Step 5 branch taken: Triggered signals (1): Why no docs are needed: The PR's only code change is |
Description
Disable only
Aspire.Deployment.EndToEnd.Tests.TypeScriptAzureProvisioningDeploymentTests.DeployAppConfigurationWithProvisioningOverrideswith[ActiveIssue("https://github.com/microsoft/aspire/issues/20815")]using QuarantineTools. KeepDeployNetworkAndPrivateDnsWithProvisioningOverridesenabled and unchanged.The infrastructure-only AppHost adds an App Configuration store with default role assignments but no application principal or identity-capable compute environment.
BicepProvisionerintentionally rejects the unbound principal. The scenario has failed since its introduction in #20131; no passing execution has been established. This is not a subscription-cutover regression. Product logic, test logic, and the existingAzureDeployerTestsno-environment failure contract remain unchanged. Re-enable this scenario once its AppHost setup is corrected.Addresses #20815. This PR intentionally leaves the issue open. No new dependencies.
Validation
./restore.sh— passed../dotnet.sh run --project tools/QuarantineTools -- -q -m activeissue -i https://github.com/microsoft/aspire/issues/20815 Aspire.Deployment.EndToEnd.Tests.TypeScriptAzureProvisioningDeploymentTests.DeployAppConfigurationWithProvisioningOverrides— passed; updated only the requested method's attribute../dotnet.sh build tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj— passed, zero warnings/errors../dotnet.sh test --project tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj --no-launch-profile -- --list-tests --filter-class '*.TypeScriptAzureProvisioningDeploymentTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'— initial discovery command failed with SDK handshake exit 12 because--list-testsmust precede--; corrected below../dotnet.sh test --project tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj --no-build --no-launch-profile --list-tests -- --filter-class '*.TypeScriptAzureProvisioningDeploymentTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'— passed; exactly one test discovered:DeployNetworkAndPrivateDnsWithProvisioningOverrides. Disabled App Configuration scenario absent../dotnet.sh test --project tests/Aspire.Deployment.EndToEnd.Tests/Aspire.Deployment.EndToEnd.Tests.csproj --no-build --no-launch-profile -- --filter-method '*.DeployAppConfigurationWithProvisioningOverrides' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'— expected zero tests ran, MTP exit 8; confirms disabled target cannot execute.git diff --check— passed.Audited deployment routing:
deployment-tests.ymluses nightly schedule and manual dispatch (including the PR deployment command), with class-scoped selection andOnlyDeploymentTests=true. The standard test enumeration excludes this project.test-trigger-map.ymlalready classifies deployment paths and runtime production dependencies as dedicated schedule/dispatch-onlyjob:deployment-e2einputs. No regular-PR consumer is being removed, and no routing changes are needed. The class retains its enabled companion scenario.No live Azure deployment or mutation was performed; companion deployment execution was not rerun locally.
Checklist
<remarks />and<code />elements on your triple slash comments?