Skip to content

Change StabilizePackageVersion condition to true - #20368

Merged
Jose Perez Rodriguez (joperezr) merged 1 commit into
release/13.6from
joperezr-patch-1
Sep 23, 2026
Merged

Jose Perez Rodriguez (joperezr) merged 1 commit into
release/13.6from
joperezr-patch-1

Conversation

@joperezr

Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20368

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20368"

@github-actions github-actions Bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Sep 23, 2026
@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot September 23, 2026 06:00
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

Selects the full PR test matrix + all PR-gated jobs (ALL) — a rule matching 'eng/Versions.props' selects ALL


Selection computed for commit fab804b.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new global default breaks normal CI channel selection and local prerelease hive packaging.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Changes the default package versioning mode from prerelease to stabilized release builds.

Changes:

  • Sets StabilizePackageVersion to true by default.
  • Consequently selects release versioning and the stable CLI channel.
File Review
eng/​Versions.props Critical: Normal CI builds may produce stable artifacts and use the stable CLI channel. Moderate: Local hive scripts may fail to copy prerelease packages due to filename mismatches.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/Versions.props
@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@joperezr

Copy link
Copy Markdown
Member Author

The failure is unrelated, seems to be #20117

@joperezr
Jose Perez Rodriguez (joperezr) marked this pull request as ready for review September 23, 2026 16:07
@joperezr
Jose Perez Rodriguez (joperezr) merged commit 63b5556 into release/13.6 Sep 23, 2026
1653 of 1665 checks passed
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Step 5 branch taken: docs_optional → build_or_ci_only

Triggered signals: none triggered (signal_count == 0; only_test_or_build_changes is advisory-only and not a gating signal).

Allowlist justification: All 1 changed file (eng/Versions.props) matches the eng/ build-configuration glob. The change is a single-line edit (StabilizePackageVersion condition flipped to true) in a build/versioning props file consumed by the build pipeline, not by any documented public API, CLI surface, or user-facing behavior. This cleanly matches the build_or_ci_only allowlist category defined in Step 5.

David Pine (IEvangelist) pushed a commit that referenced this pull request Oct 1, 2026
## Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

Fixes # (issue)

## Checklist

- Is this feature complete?
  - [ ] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [ ] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [ ] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-codeflow for labeling automated codeflow. intentionally a different color!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants