Fix dashboard terminal documentation link - #20230
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ad3e0bea-59ee-4c43-9bfa-31743aee3d11
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20230Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20230" |
Tests selector10 / 99 PR test projects · 3 PR jobs, from 2 changed files. Selected PR test projects (10 / 99)
Selected PR jobs (3)
How these were chosen — grouped by what changed
🔧 📦 affected project 📦 affected project 🧪 Job reasons
Selection computed for commit |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation and focused test are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects the dashboard terminal help link and updates its regression test.
Changes:
- Changes the documentation URL to the intended singular path.
- Updates the component test assertion.
| File | Description |
|---|---|
src/Aspire.Dashboard/Components/Layout/TerminalDock.razor |
Corrects the terminal documentation link. |
tests/Aspire.Dashboard.Components.Tests/Layout/TerminalDockTests.cs |
Verifies the corrected URL. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
✅ No documentation update needed. Step 5 branch taken: Triggered signals: none ( Why
No new or changed public types, methods, options, or resource strings are introduced - only the destination of an existing external Docs-site check: Searched No docs PR is needed. |
|
The CI build failed due to test failure(s) that appear unrelated to the PR changes. These may be flaky tests. Suspected flaky test(s):
Suggested actions:
You can re-run the failed jobs from the workflow run page. |
Description
Correct the terminal dock's More information link to point to the intended terminal documentation.
https://aka.ms/aspire/dashboard-terminalshttps://aka.ms/aspire/dashboard-terminalUpdate the existing component test assertion to match. The focused
WatchUpdates_ReplaceSnapshotAndSelectAppHostTerminalstest passes (1 test), and no references to the incorrect URL remain.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?