Reject numeric persistence mode values in dashboard configuration

[Muhammad Bilal (MuhammadBilal64)]

Description

PostConfigureDashboardOptions uses Enum.TryParse followed by Enum.IsDefined to validate the --persistence value. Enum.TryParse accepts numeric strings that map to defined enum values, so --persistence 1 silently succeeded and initialized the Dashboard in Run mode, even though only the named values None, Run, and Resume are documented as valid.

This adds a check to reject numeric input before attempting the enum parse, so numeric values are now correctly rejected with the existing parse-error message. Added a regression test covering this case.

Fixes #19781

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19966

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19966"

[Muhammad Bilal (MuhammadBilal64)]

@microsoft-github-policy-service agree

[Copilot]

🟢 Approval recommended

The focused validation change correctly addresses the reported issue and includes appropriate regression coverage.

Pull request overview

Rejects numeric dashboard persistence modes while preserving named values.

Changes:

• Rejects numeric values before enum parsing.
• Adds regression coverage for --persistence 1.

File summaries

File	Description
src/Aspire.Dashboard/Configuration/PostConfigureDashboardOptions.cs	Rejects numeric persistence modes.
tests/Aspire.Dashboard.Tests/DashboardOptionsTests.cs	Verifies numeric input produces a validation error.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[Muhammad Bilal (MuhammadBilal64)]

Hi James Newton-King (@JamesNK) Adam Ratzman (@adamint), gentle reminder on this PR when you get a chance. Would appreciate a review. Thanks!

[Muhammad Bilal (MuhammadBilal64)]

Hi James Newton-King (@JamesNK) Adam Ratzman (@adamint), following up on this PR since it’s still awaiting a maintainer review. Copilot’s review found no issues and recommended approval. When you get a chance, could you please take a look? Thanks!