Skip to content

Update available external dependencies - #19440

Merged
Jose Perez Rodriguez (joperezr) merged 2 commits into
mainfrom
joperezr-update-nuget-dependencies
Aug 17, 2026
Merged

Jose Perez Rodriguez (joperezr) merged 2 commits into
mainfrom
joperezr-update-nuget-dependencies

Conversation

@joperezr

Copy link
Copy Markdown
Member

Description

Updates external NuGet dependencies whose latest recommended versions are already available from the repository's internal feeds. Packages still awaiting internal-feed ingestion are intentionally deferred to a follow-up draft PR.

This also updates three Qdrant sample/test call sites from the obsolete SearchAsync API to QueryAsync, as required by Qdrant.Client 1.19.0, and aligns the OpenTelemetry package family at 1.17.0 where stable versions are available.

Validation:

  • Repository restore succeeds using the configured internal feeds.
  • Repository compilation completes; the final build target is blocked only by the local machine not having Windows SDK makecat.exe installed.
  • Qdrant test project: 24 tests pass; 6 container functional tests cannot run because Docker Desktop is offline.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 39de214e-f364-4c5c-9fab-d713330af0e4
Copilot AI balanced review requested due to automatic review settings August 17, 2026 19:01
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19440

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19440"

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 17, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates external NuGet dependencies and adapts Qdrant usages to its current query API.

Changes:

  • Updates external dependency versions.
  • Aligns stable OpenTelemetry packages at 1.17.0.
  • Replaces obsolete Qdrant SearchAsync calls with QueryAsync.
Show a summary per file
File Description
Directory.Packages.props Updates centrally managed dependencies.
eng/Versions.props Updates OpenTelemetry-related versions.
tests/Aspire.Hosting.Qdrant.Tests/QdrantFunctionalTests.cs Migrates Qdrant functional tests to QueryAsync.
playground/Qdrant/Qdrant.ApiService/Program.cs Migrates the Qdrant sample search endpoint.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 39de214e-f364-4c5c-9fab-d713330af0e4

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 5/5 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

Runs the full test matrix + all jobs (ALL) — a rule matching 'Directory.Packages.props' selects ALL


Selection computed for commit c177125.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@joperezr
Jose Perez Rodriguez (joperezr) merged commit dc6bb0e into main Aug 17, 2026
729 of 735 checks passed
@joperezr
Jose Perez Rodriguez (joperezr) deleted the joperezr-update-nuget-dependencies branch August 17, 2026 20:53
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 13.6 milestone Aug 17, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Step 5 branch taken: docs_optional → dependency_bump

Triggered signals (1): pr_body_has_deprecation_marker — evidence: PR body mentions "call sites from the obsolete SearchAsync API to QueryAsync, as required by Qdrant.Client 1.19.0".

Why this is a false-positive/allowlisted skip: All 5 changed files are:

  • Directory.Packages.props, eng/Versions.props — pure NuGet version bumps to packages already available from internal feeds.
  • playground/Qdrant/Qdrant.ApiService/Program.cs, tests/Aspire.Hosting.Qdrant.Tests/QdrantFunctionalTests.cs — internal sample/test call-site migration from Qdrant.Client's own obsolete SearchAsync to QueryAsync. This is a change to Qdrant's third-party client API surface, not an Aspire-owned public API, and is not user-facing Aspire documentation content.
  • src/Components/Aspire.Seq/ConfigurationSchema.json — regenerated appsettings.json schema reflecting existing OTLP exporter options (Compression, Protocol, etc.) that are already generic/auto-generated schema content, not new documented behavior.

No new Aspire public API, CLI option, hosting/client integration behavior, or documented default changed. This matches the dependency_bump allowlist category: package version updates with no behavior or surface change in this PR.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ CI Failure Analysis: Possible Flaky Test(s)

The CI build failed due to test failure(s) that appear unrelated to the PR changes. These may be flaky tests.

Suspected flaky test(s):

  • Infrastructure.Tests.DownloadNativeArchivesTests.FailsWhenOneArtifactDownloadFails_ButReportsAllResults in job Tests / Infrastructure / Infrastructure (ubuntu-latest)
    • Error: System.Net.HttpListenerException : Address already in use
    • Stack Trace (first frames):
      at System.Net.HttpEndPointManager.GetEPListener(String host, Int32 port, HttpListener listener, Boolean secure)
         at System.Net.HttpEndPointManager.AddPrefixInternal(String p, HttpListener listener)
         at System.Net.HttpEndPointManager.AddListener(HttpListener listener)
         at System.Net.HttpListener.Start()
         at Infrastructure.Tests.DownloadNativeArchivesTests.MockAzdoServer.Start()
      
    • Why likely flaky: Port-binding race condition in a mock HTTP listener used by the test; the test/file is unrelated to the PR's dependency-version changes.

Suggested actions:

  • Re-run the failed CI jobs to confirm if the failure is intermittent
  • If the test continues to fail, consider quarantining it using /quarantine-test <test name> <issue URL>
  • Search existing issues to see if this test is already known to be flaky

You can re-run the failed jobs from the workflow run page.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants