Update to latest Configuration Binder source generator - #1616
Merged
Eric Erhardt (eerhardt) merged 2 commits intoJan 11, 2024
Merged
Eric Erhardt (eerhardt) merged 2 commits into
Eric Erhardt (eerhardt) merged 2 commits into
Conversation
Now that 8.0.1 has shipped, we can remove the workarounds added in microsoft#535.
Eric Erhardt (eerhardt)
requested review from
Jose Perez Rodriguez (joperezr) and
Sébastien Ros (sebastienros)
January 10, 2024 00:34
ghost
added
the
area-integrations
| <MicrosoftExtensionsOptionsPackageVersion>8.0.0</MicrosoftExtensionsOptionsPackageVersion> | ||
| <MicrosoftExtensionsOptionsPackageVersion>8.0.1</MicrosoftExtensionsOptionsPackageVersion> | ||
| <MicrosoftExtensionsPrimitivesPackageVersion>8.0.0</MicrosoftExtensionsPrimitivesPackageVersion> | ||
| <MicrosoftAspNetCoreOpenApiPackageVersion>8.0.0</MicrosoftAspNetCoreOpenApiPackageVersion> |
Member
Author
There was a problem hiding this comment.
Note that all the libraries from dotnet/aspnetcore now have a 8.0.1 version because they ship every month, whether there are changes or not. I didn't update here because I don't think we should unless there is a blocking bug we need.
Thoughts?
Contributor
There was a problem hiding this comment.
Can we introduce $(AspNetVersion) ?
Member
Author
There was a problem hiding this comment.
Let's say we did and we wanted to consume a new patch version Microsoft.AspNetCore.OpenApi, would it make sense for all the packages to go to 8.0.1 just because we needed a new version of OpenApi?
Sébastien Ros (sebastienros)
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that 8.0.1 has shipped, we can remove the workarounds added in #535.
Microsoft Reviewers: Open in CodeFlow