Skip to content

Add column title for details column on the 'Traces' page - #1574

Merged
James Newton-King (JamesNK) merged 3 commits into
microsoft:mainfrom
stbau04:stbau04/On-the-dashboard-no-column-title-for-view-column-on-the-Traces-board
Jan 11, 2024
Merged

Add column title for details column on the 'Traces' page#1574
James Newton-King (JamesNK) merged 3 commits into
microsoft:mainfrom
stbau04:stbau04/On-the-dashboard-no-column-title-for-view-column-on-the-Traces-board

Conversation

@stbau04

@stbau04 Stephan Bauer (stbau04) commented Jan 6, 2024 •
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

Add column title for details column on the 'Traces' page

Fixes: #1535

Traces:
grafik

Structured logs:
grafik

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jan 6, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jan 6, 2024
@stbau04
Stephan Bauer (stbau04) marked this pull request as draft January 6, 2024 21:23
@stbau04
Stephan Bauer (stbau04) marked this pull request as ready for review January 6, 2024 21:23
@stbau04
Stephan Bauer (stbau04) force-pushed the stbau04/On-the-dashboard-no-column-title-for-view-column-on-the-Traces-board branch 3 times, most recently from 4848c88 to ea10ea0 Compare January 7, 2024 12:15
@stbau04

Stephan Bauer (stbau04) commented Jan 7, 2024

Copy link
Copy Markdown
Contributor Author

FYI: it took me four runs to pass all checks
Once a unit test failed due to a kubeconfig that could not be deleted/modified, once the linux tests timed out and once the windows tests timed out. I don't think that the problems are related to my changes, are there any known issues with the pipeline?

@tlmii Tim Mulholland (tlmii) added area-dashboard and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Jan 7, 2024
adamint
Adam Ratzman (adamint) requested changes Jan 10, 2024
View reviewed changes
Comment thread src/Aspire.Dashboard/Components/Pages/Traces.razor Outdated
Comment thread src/Aspire.Dashboard/Components/Pages/StructuredLogs.razor Outdated
@dotnet-policy-service dotnet-policy-service Bot added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 10, 2024
@adamint

Adam Ratzman (adamint) commented Jan 10, 2024

Copy link
Copy Markdown
Member

are there any known issues with the pipeline

Not AFAIK Stephan Bauer (@stbau04), let me know if you continue to run into this pipeline issue.

@JamesNK
James Newton-King (JamesNK) merged commit 698a7f1 into microsoft:main Jan 11, 2024
@JamesNK

James Newton-King (JamesNK) commented Jan 11, 2024

Copy link
Copy Markdown
Member

Thanks!

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamesNK James Newton-King (JamesNK) JamesNK approved these changes
@adamint Adam Ratzman (adamint) adamint approved these changes

Assignees

@drewnoakes Drew Noakes (drewnoakes)

Labels

area-dashboard community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire] On the dashboard, no column title for view column on the 'Traces' board.

5 participants

@stbau04 @adamint @JamesNK @drewnoakes @tlmii