Skip to content

[automated] Investigate renamed-file handling in selective PR CI #19786

Description

@radical

[automated] PR #19486 showed that a same-commit rename can expose the old path as an unmatched deletion and safely fall back to ALL.

The investigation found that exempting unmatched old paths is unsafe: a directory rule can have consumers beyond the moved file, and the destination can be ignored or removed by prefiltering. Either case could silently under-select tests. The selector should therefore retain the run-all fallback.

PR #19790 contains adjacent safety fixes found during the investigation. Both selector layers now share NUL-delimited diff parsing, literal backslashes are preserved, raw paths are escaped for Markdown, and truncated diff streams fail loudly. It deliberately does not suppress the safe ALL result for PR #19486.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-engineering-systemsinfrastructure helix infra engineering repo stufftriage:bot-seenAspire triage bot has seen this issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions