fix: avoid repeated TypeScript API sidebar catalogs - #1757
Merged
David Pine (IEvangelist) merged 2 commits intoSep 25, 2026
Merged
David Pine (IEvangelist) merged 2 commits into
David Pine (IEvangelist) merged 2 commits into
Conversation
Keep full module catalogs on their overview pages and render compact current-page navigation on API detail pages. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5eeee6c8-e0b2-4836-96ff-a9726e92b2ee
Copilot started reviewing on behalf of
David Pine (IEvangelist)
September 25, 2026 17:22
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The E2E test must navigate to the item page before locating the member sidebar method link.
Review effort: Lite
Findings: None
What changed in this PR
Refactors TypeScript API navigation to avoid repeated catalogs on detail pages.
Changes:
- Adds compact contextual sidebars.
- Normalizes API links and anchors.
- Adds unit/E2E coverage and documentation.
| File | Description |
|---|---|
src/frontend/tests/unit/ts-api-sidebar.vitest.test.ts |
Tests sidebar generation. |
src/frontend/tests/unit/api-reference-routes.vitest.test.ts |
Tests API route normalization. |
src/frontend/tests/e2e/ts-api-sidebar.spec.ts |
Tests sidebar navigation; one locator targets the wrong page context. |
src/frontend/src/utils/ts-api-sidebar.ts |
Builds compact contextual sidebars. |
src/frontend/src/utils/api-reference-routes.ts |
Normalizes API sidebar URLs. |
src/frontend/src/route-data-middleware.ts |
Applies sidebar link normalization. |
src/frontend/src/pages/reference/api/typescript/[module]/index.astro |
Supplies module-page sidebar context. |
src/frontend/src/pages/reference/api/typescript/[module]/[item]/index.astro |
Supplies item-page sidebar context. |
src/frontend/src/pages/reference/api/typescript/[module]/[item]/[member]/index.astro |
Supplies member-page sidebar context. |
src/frontend/package.json |
Includes new unit tests. |
CONTRIBUTING.md |
Documents sidebar navigation requirements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Eric Erhardt (eerhardt)
approved these changes
Sep 25, 2026
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5eeee6c8-e0b2-4836-96ff-a9726e92b2ee
David Pine (IEvangelist)
deleted the
ievangelist-release-build-performance
branch
September 25, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep full module catalogs on their overview pages and render compact current-page navigation on API detail pages.
Summary
Third-party links and affiliations
Validation