Skip to content

fix(workflows): allow fork PRs in pr-review-panel #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 1 commit into from
Apr 21, 2026
Merged

fix(workflows): allow fork PRs in pr-review-panel #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/pr-review-panel.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion .github/workflows/pr-review-panel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@ description: Multi-persona expert panel review of labelled PRs, posting a single
# Trigger: pull_request (NOT pull_request_target -- gh-aw blocks the latter on
# public repos). Cost-gate: only runs when a maintainer applies `panel-review`.
# `synchronize` re-runs on new pushes once the PR carries the label.
# Default fork policy (no `forks:` field) restricts to same-repo PRs only.
# `forks: ["*"]` allows fork PRs to be reviewed; the trust gate is the label
# itself, which only write-access maintainers can apply.
Comment on lines 5 to +9
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header comment says the workflow "only runs when a maintainer applies panel-review", but the trigger includes pull_request.synchronize. In the compiled workflow, synchronize currently runs at least the pre_activation job even when the PR is not labeled. Either tighten the synchronize path to require the label (recommended, especially now that forks are allowed) or update the comment to match the actual behavior.

See below for a potential fix:

# public repos). A maintainer applying `panel-review` is the intent gate for
# the actual panel review, but the workflow also listens to `synchronize`.
# That means new pushes can start the workflow even before the label is
# present. `forks: ["*"]` allows fork PRs to be reviewed; the trust gate for
# the review itself remains the label, which only write-access maintainers can
# apply.

Copilot uses AI. Check for mistakes.
on:
pull_request:
types: [labeled, synchronize]
names: [panel-review]
forks: ["*"]

# Agent job runs READ-ONLY. Safe-output jobs are auto-granted scoped write.
permissions:
Expand Down
Loading