fix(cache): handle ValueError from parsed.port on Windows file:// URLs

[danielmeppiel]

Problem

Windows CI (run 26252988143) failed with:

ValueError: Port could not be cast to integer value as '\\Users\\runneradmin\\AppData\\Local\\Temp\\...\\bare.git'

at src/apm_cli/cache/url_normalize.py:86 (port = parsed.port).

Root cause: On Windows, urlparse("file://C:\\path\\bare.git") places C:\path... into the netloc. Python's parsed.port property splits the netloc on : and interprets the drive-letter colon as a host:port separator -- raising ValueError because the 'port' isn't a digit. This crashed cache_shard_key() for every test that constructed a file://{tmp_path} URL (e.g. TestGetCheckoutLayout.test_full_variant_layout).

Linux/macOS were unaffected because their tmp paths start with /, producing an empty netloc.

Fix

Wrap hostname/username/port extraction in try/except ValueError. On failure, fall back to the raw lowercased netloc as the authority. This keeps cache-key derivation:

• Non-raising -- never crashes on malformed netlocs
• Deterministic -- same URL always yields same shard
• Per-URL distinct -- different Windows paths (C:\repo_a.git vs C:\repo_b.git) still get different shards (the prior trivial fix collapsed them all to file://c)

Tests

Added two regression tests in tests/unit/cache/test_url_normalize.py:

• test_windows_file_url_does_not_raise -- verifies no ValueError
• test_windows_file_urls_distinct_paths_distinct_keys -- verifies shard-key distinctness

Validation

• uv run --extra dev pytest tests/unit/cache/ -q -> 44 passed
• uv run --extra dev ruff check src/ tests/ -> All checks passed
• uv run --extra dev ruff format --check src/ tests/ -> 1046 files already formatted
• uv run --extra dev python -m pylint --disable=all --enable=R0801 --min-similarity-lines=10 --fail-on=R0801 src/apm_cli/ -> 10.00/10
• bash scripts/lint-auth-signals.sh -> auth-signal lint clean

[Copilot]

Pull request overview

Fixes Windows CI failures in the cache URL normalizer by preventing urllib.parse from raising ValueError when encountering malformed file://C:\... URLs (where the drive-letter colon is misinterpreted as a host:port separator).

Changes:

• Wrap parsed.hostname / parsed.port extraction in try/except ValueError and fall back to a deterministic authority derived from parsed.netloc.
• Add unit regression tests to ensure Windows-style file://C:\... inputs do not raise and produce distinct cache shard keys for distinct paths.

Show a summary per file

File	Description
tests/unit/cache/test_url_normalize.py	Adds regression tests for Windows-style malformed file:// URLs to ensure shard-key derivation doesn’t raise and remains distinct per path.
src/apm_cli/cache/url_normalize.py	Catches ValueError from urlparse port/hostname parsing and falls back to raw netloc to keep cache-key derivation deterministic on Windows.

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 1

[danielmeppiel]

Good catch -- fixed in 2573439. The fallback now splits userinfo on @, drops everything after : in the user portion, then lowercases, mirroring Step 4 in the happy path. Added test_fallback_strips_password_from_netloc to lock it in.