Skip to content

refactor(tests): harden test suite against silent regressions - #45

Merged
Mowri Mohan (mowree) merged 1 commit into
microsoft:mainfrom
HDMowri:refactor/two-medium-config-python-dataclasses
Apr 14, 2026
Merged

refactor(tests): harden test suite against silent regressions#45
Mowri Mohan (mowree) merged 1 commit into
microsoft:mainfrom
HDMowri:refactor/two-medium-config-python-dataclasses

Conversation

@HDMowri

@HDMowri Mowri Mohan (HDMowri) commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Fix _extract_event_data: data=None no longer leaks into DomainEvent.data
(session.idle events were producing spurious {data: None} entries).

Tests: spec= on all mocks, exact-value assertions replace is not None,
inspect.getsource checks replaced with behavioral equivalents. Deleted
test_sdk_api_conformance.py and test_timeout_alignment.py (YAML config
gone in PR #44). New: test_sdk_client_injection.py, flatten regression
guard, malformed JSON tool args resilience.

Contracts: sdk-boundary, event-vocabulary, behaviors, provider-protocol
updated to reflect dataclass-based config and new invariants.

Gates: 1157 passed (Windows, all tests incl. live), 2 xfailed (Unix
chmod -- expected), 0 deselected. WSL: 1159 passed, 98% branch coverage.
ruff: 0 errors. pyright: 0 errors.

@HDMowri
Mowri Mohan (HDMowri) force-pushed the refactor/two-medium-config-python-dataclasses branch 4 times, most recently from 2f83a5b to 1857f2e Compare April 14, 2026 01:14
@HDMowri Mowri Mohan (HDMowri) changed the title refactor(config+tests): Two-Medium architecture — Python dataclasses replace YAML refactor(tests): harden test suite against silent regressions Apr 14, 2026
@HDMowri
Mowri Mohan (HDMowri) force-pushed the refactor/two-medium-config-python-dataclasses branch from 1857f2e to ea4a0fc Compare April 14, 2026 01:19
Fix _extract_event_data: data=None no longer leaks into DomainEvent.data
(session.idle events were producing spurious {data: None} entries).

Tests: spec= on all mocks, exact-value assertions replace is not None,
inspect.getsource checks replaced with behavioral equivalents. Deleted
test_sdk_api_conformance.py and test_timeout_alignment.py (YAML config
gone in PR microsoft#44). New: test_sdk_client_injection.py, flatten regression
guard, malformed JSON tool args resilience.

Contracts: sdk-boundary, event-vocabulary, behaviors, provider-protocol
updated to reflect dataclass-based config and new invariants.

Gates: 1157 passed (Windows, all tests incl. live), 2 xfailed (Unix
chmod -- expected), 0 deselected. WSL: 1159 passed, 98% branch coverage.
ruff: 0 errors. pyright: 0 errors.
@HDMowri
Mowri Mohan (HDMowri) force-pushed the refactor/two-medium-config-python-dataclasses branch from ea4a0fc to 15ec596 Compare April 14, 2026 01:31
@mowree
Mowri Mohan (mowree) merged commit 6f963cb into microsoft:main Apr 14, 2026
1 check passed
@HDMowri
Mowri Mohan (HDMowri) deleted the refactor/two-medium-config-python-dataclasses branch May 14, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants