fix(codeowners): add @imran-siddique to *.md reviewer line#3022
Merged
Conversation
The *.md override shadowed the default * line, meaning @imran-siddique approvals did not satisfy the CODEOWNER requirement for PRs touching markdown files. This left PRs approved by the maintainer stuck on REVIEW_REQUIRED despite the intent of the default ownership rule. Signed-off-by: Imran Siddique <imran.siddique@opaque.co> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
*.mdCODEOWNERS override shadowed the default*line, so@imran-siddiqueapprovals were not counted for PRs touching markdown files. This left maintainer-approved PRs stuck onREVIEW_REQUIRED(e.g. #3013, #2994, #2973, #2766).The fix is one character: add
@imran-siddiqueto the*.mdline, consistent with how every other path rule in this file already includes both maintainers.Test plan
🤖 Generated with Claude Code