Python: clarify skill script argument guidance - #7695
Merged
Conversation
Ruiming Zhao (uuzzrm)
temporarily deployed
to
github-app-auth
August 17, 2026 13:17 — with
GitHub Actions
Inactive
Ruiming Zhao (uuzzrm)
temporarily deployed
to
github-app-auth
August 17, 2026 13:17 — with
GitHub Actions
Inactive
Ruiming Zhao (uuzzrm)
had a problem deploying
to
github-app-auth
August 17, 2026 13:17 — with
GitHub Actions
Error
Ruiming Zhao (uuzzrm)
marked this pull request as ready for review
August 17, 2026 13:18
Ruiming Zhao (uuzzrm)
temporarily deployed
to
github-app-auth
August 17, 2026 13:18 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the skills prompt guidance to clarify how to pass script arguments for inline vs file-based scripts, and adds a regression test to ensure the prompt includes this distinction.
Changes:
- Expand
SCRIPT_RUNNER_INSTRUCTIONSto describeargsas either a JSON object (named args) or an array (CLI positional args). - Add a test asserting the default prompt contains the new guidance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/packages/core/agent_framework/_skills.py | Clarifies prompt instructions for run_skill_script argument shapes (object vs array). |
| python/packages/core/tests/core/test_skills.py | Adds a regression test to ensure the prompt includes the new argument-shape guidance. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Ruiming Zhao (uuzzrm)
temporarily deployed
to
github-app-auth
August 17, 2026 13:22 — with
GitHub Actions
Inactive
Ruiming Zhao (uuzzrm)
temporarily deployed
to
github-app-auth
August 17, 2026 13:23 — with
GitHub Actions
Inactive
Ruiming Zhao (uuzzrm)
temporarily deployed
to
github-app-auth
August 17, 2026 17:22 — with
GitHub Actions
Inactive
Ruiming Zhao (uuzzrm)
temporarily deployed
to
github-app-auth
August 17, 2026 17:27 — with
GitHub Actions
Inactive
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
Giles Odigwe (giles17)
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
SCRIPT_RUNNER_INSTRUCTIONScurrently tells agents to passargsas an object, while therun_skill_scriptschema also accepts string arrays for file-based CLI scripts. That guidance can steer agents away from a supported argument shape. This change aligns the default prompt with the existing schema and runtime behavior.Description & Review Guide
args.test_skills.pysuite passes with 537 passed and 11 skipped; Ruff check and format checks pass.uv buildsuccessfully produced the core sdist and wheel. The repositorypoe build -P corewrapper then stops at itssh-based dist move becauseshis unavailable in this Windows environment.This PR was prepared with AI assistance; I reviewed the patch and verified the focused behavior locally.
Related Issue
Fixes #7691
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix) — a workflow keeps the label and the title prefix in sync automatically.