.NET: Add checkpoint on super step started event: issue #4280 - #4604
.NET: Add checkpoint on super step started event: issue #4280#4604Eric Gold (elgold92) wants to merge 19 commits into
Conversation
…ely b/c the test definitions are now wrong
…c definition. I think this is correct, but the test now hangs, likely because the first checkpoint (or it's related data structures) we're now creating aren't initialized correctly.
…ShouldPersist_CheckpointedAsync test definition
There was a problem hiding this comment.
Pull request overview
Adds support for creating/checkpointing workflow state at the SuperStepStarted boundary so runs can resume from “pre-delivery” checkpoints (addressing #4280), and updates tests accordingly.
Changes:
- Add a
CheckpointInfo?field toSuperStepStartInfoand populate it onSuperStepStartedEvent. - Create a checkpoint at the start of each superstep (capturing pre-delivery queued messages) by extending runner state export to accept an override
StepContext. - Update and expand unit tests to account for the additional checkpoints and validate parent chaining/resume behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/InProcessStateTests.cs | Updates expected checkpoint count due to start+end checkpointing per superstep. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/CheckpointParentTests.cs | Extends tests to include checkpoints emitted on SuperStepStartedEvent and adds new resume/count assertions. |
| dotnet/src/Microsoft.Agents.AI.Workflows/SuperStepStartInfo.cs | Adds Checkpoint property to expose the checkpoint emitted at superstep start. |
| dotnet/src/Microsoft.Agents.AI.Workflows/InProc/InProcessRunnerContext.cs | Allows exporting runner state from an alternate StepContext (pre-delivery snapshot). |
| dotnet/src/Microsoft.Agents.AI.Workflows/InProc/InProcessRunner.cs | Saves a checkpoint before superstep execution and wires it into the started event. |
| dotnet/src/Microsoft.Agents.AI.Workflows/InProc/InProcStepTracer.cs | Plumbs the start-checkpoint into SuperStepStartedEvent payload. |
…tParentTests.cs rename local variable Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Copilot open a new pull request to apply changes based on the comments in this thread. Changes look to be generally minor improvements. |
…tParentTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Review: Checkpoint on Super Step StartedThis resolves #4280 — enabling checkpoint creation at Observations
SuggestionConsider adding a test that verifies checkpoint restoration from a This is a solid contribution to workflow reliability! |
Motivation and Context
Resolves #4280, allowing workflows to resume from checkpoints saved from SuperStepStarted events.
Description
Adds
CheckpointInfo?field to theSuperStepStartInfoclass, populating this information in the InProcessRunner and InProcStepTracer. Also updates associated unit tests to expect more checkpoints to be created on checkpointed workflows.