Skip to content

Improve Go API consistency review output - #820

Merged
Quim Muntal (qmuntal) merged 5 commits into
mainfrom
griffinbird-improve-parity-review-output
Aug 24, 2026
Merged

Improve Go API consistency review output#820
Quim Muntal (qmuntal) merged 5 commits into
mainfrom
griffinbird-improve-parity-review-output

Conversation

@griffinbird

@griffinbird Ben Griffin (griffinbird) commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Why

Make automated parity reviews faster for the Golang compiler team to verify and act on. The workflow now makes its scope and evidence explicit, and avoids low-confidence or duplicate inline comments.

Changes

  • Classify each review as public API, user-visible behavior, examples, and/or internal-only.
  • Require summary comments to include the changed Go contract, exact upstream .NET/Python evidence, and a clear result.
  • Require inline findings to cite the specific upstream source, symbol, test, or sample supporting the mismatch.
  • Limit inline findings to high-confidence, actionable issues.
  • Consolidate repeated instances of the same root cause into one representative comment with the complete affected scope.
  • Regenerate the workflow lock with the repository's existing gh-aw v0.83.4 baseline.

Impact

This does not change triggers, permissions, labels, required human approvals, or merge behavior. It improves the information available before the Golang compiler team performs its required review.

Validation

gh aw compile go-api-consistency-review --strict

Compilation completed successfully with 0 warnings.

Follow-up

Copilot AI lite review requested due to automatic review settings August 10, 2026 06:42
@griffinbird
Ben Griffin (griffinbird) requested a review from a team as a code owner August 10, 2026 06:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Go API consistency review workflow guidance and regenerates the corresponding gh-aw lock artifacts to make automated parity reviews more explicit, evidence-driven, and actionable for maintainers.

Changes:

  • Tightens the review rubric to require scope classification, explicit upstream evidence, and high-confidence actionable findings.
  • Regenerates the compiled workflow lock file for gh-aw v0.85.4 (including updated runtime/tooling metadata).
  • Updates repository workflow/lock metadata files used by the automation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/go-api-consistency-review.md Adds stricter parity-review process guidance (scope classification, upstream evidence citation, consolidation rules).
.github/workflows/go-api-consistency-review.lock.yml Regenerated compiled workflow lock output for gh-aw v0.85.4 with updated pinned tooling/metadata.
.github/aw/actions-lock.json Updates the pinned gh-aw setup action entry used by gh-aw metadata locking.
.gitattributes Adjusts how workflow lock files are treated by Git/Linguist.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .gitattributes Outdated
Comment on lines 1139 to 1143
runs-on: ubuntu-slim
permissions:
contents: read
actions: read
issues: write
pull-requests: write
Comment thread .github/aw/actions-lock.json Outdated
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Go API Consistency Review

Scope: internal-only (.github/ workflow files only)
Changed Go contract: None
Upstream evidence reviewed: N/A — no Go source changes
Result: Out of scope

This PR modifies only .github/workflows/go-api-consistency-review.md and the associated .lock.yml file. No exported Go APIs, user-visible behavior, or examples/ content were changed. Cross-repo parity review does not apply.

Generated by Go API Consistency Review Agent · sonnet46 · 10.7 AIC · ⌖ 4 AIC · ⊞ 6.1K ·

@karianna

Copy link
Copy Markdown
Member

Ben Griffin (@griffinbird) Apologies but are you able to rebase?

Ben Griffin and others added 5 commits August 24, 2026 14:54
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@griffinbird
Ben Griffin (griffinbird) force-pushed the griffinbird-improve-parity-review-output branch from 0816813 to c81be58 Compare August 24, 2026 04:58
@github-actions github-actions Bot added area:github Changes files in the github area size:small At most 30 changed lines across at most 2 files labels Aug 24, 2026
@griffinbird

Ben Griffin (griffinbird) commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto the latest main and resolved the workflow conflict by preserving the newer port-review behavior. I also regenerated the lock file with the repository's gh-aw v0.83.4 baseline.

@github-actions github-actions Bot added kind:ci Changes CI, build, or repository automation pending-auto-risk Automatic risk classification is in progress risk:low Limited blast radius and straightforward rollback and removed pending-auto-risk Automatic risk classification is in progress labels Aug 24, 2026

@qmuntal Quim Muntal (qmuntal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit 3d3ca3b Aug 24, 2026
29 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the griffinbird-improve-parity-review-output branch August 24, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:github Changes files in the github area kind:ci Changes CI, build, or repository automation risk:low Limited blast radius and straightforward rollback size:small At most 30 changed lines across at most 2 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants