Skip to content

Publish experimental VersionInfo API - #5001

Merged
Scott Jones (Scottj1s) merged 3 commits into
mainfrom
user/sjones/publish_versioninfo_api
Jan 8, 2025
Merged

Publish experimental VersionInfo API#5001
Scott Jones (Scottj1s) merged 3 commits into
mainfrom
user/sjones/publish_versioninfo_api

Conversation

@Scottj1s

@Scottj1s Scott Jones (Scottj1s) commented Jan 3, 2025

Copy link
Copy Markdown
Member

Reverts "Make VersionInfo [Experimental] until it is fully working (#3542)"

@codendone

Mike Crider (codendone) commented Jan 3, 2025

Copy link
Copy Markdown
Collaborator

Has this API been through API review, or is this just prep for when API review completes?

@Scottj1s

Scott Jones (Scottj1s) commented Jan 3, 2025

Copy link
Copy Markdown
Member Author

Has this API been through API review, or is this just prep for when API review completes?

I assumed it had been reviewed before, and was made experimental because it was broken (due to missing clcompile preprocessor definitions), per #3542. I'll confirm.

@DrusTheAxe

Howard Kapustein (DrusTheAxe) commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Has this API been through API review, or is this just prep for when API review completes?

I assumed it had been reviewed before, and was made experimental because it was broken (due to missing clcompile preprocessor definitions), per #3542. I'll confirm.

Yes it went thru review. Spec's history mentions it
0616493
...

  • Incorporated API Review feedback
    ...

And...there we go. The PR with API Review comments
https://github.com/microsoft/WindowsAppSDK/pull/2893/files/60f13b9818a47d98fe6fa538a2d4b6cf37cc0d03

You're cleared for flight captain. Safe travels :-)

DrusTheAxe
Howard Kapustein (DrusTheAxe) approved these changes Jan 3, 2025
View reviewed changes

@DrusTheAxe Howard Kapustein (DrusTheAxe) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrusTheAxe Howard Kapustein (DrusTheAxe) added area-VersionInfo Topics related to semantic versioning and the VersionInfo API and removed needs-triage labels Jan 3, 2025
@DrusTheAxe Howard Kapustein (DrusTheAxe) added this to the 1.7 milestone Jan 3, 2025
@DrusTheAxe

Howard Kapustein (DrusTheAxe) commented Jan 3, 2025

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 3, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s

Scott Jones (Scottj1s) commented Jan 7, 2025

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 7, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

codendone
Mike Crider (codendone) requested changes Jan 8, 2025
View reviewed changes
Comment thread test/VersionInfo/VersionInfoTests.cpp Outdated
@Scottj1s

Scott Jones (Scottj1s) commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 8, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s
Scott Jones (Scottj1s) enabled auto-merge (squash) January 8, 2025 01:59
@Scottj1s
Scott Jones (Scottj1s) merged commit 80e530d into main Jan 8, 2025
@Scottj1s
Scott Jones (Scottj1s) deleted the user/sjones/publish_versioninfo_api branch January 8, 2025 03:30
This was referenced Dec 18, 2025
Closed
Closed
Closed
This was referenced Jan 14, 2026
Closed
Merged
Closed
@dependabot dependabot Bot mentioned this pull request Jan 26, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Feb 2, 2026
Merged
This was referenced Feb 11, 2026
Closed
Open
@guimafelipe Felipe G (guimafelipe) mentioned this pull request Feb 20, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Mar 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrusTheAxe Howard Kapustein (DrusTheAxe) DrusTheAxe approved these changes
@codendone Mike Crider (codendone) codendone approved these changes

Assignees

No one assigned

Labels

area-VersionInfo Topics related to semantic versioning and the VersionInfo API

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@Scottj1s @codendone @DrusTheAxe