[OAuth2Manager] Remove APIs for Implicit grant type - #4979
Merged
Akanksha Patel (akanpatel2206) merged 4 commits intoDec 23, 2024
Merged
Akanksha Patel (akanpatel2206) merged 4 commits into
Akanksha Patel (akanpatel2206) merged 4 commits into
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Godly T.Alias (godlytalias)
approved these changes
Dec 18, 2024
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Saharsh Ananta Jaiswal (Saharsh979)
approved these changes
Dec 19, 2024
Ayush Jaiswal (ayushjai30)
approved these changes
Dec 19, 2024
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -39,47 +39,6 @@ and OAuth 2.0 for Native Apps [RFC 8252](https://tools.ietf.org/html/rfc8252). | |||
|
|
|||
| ## Perform OAuth 2.0 (c++) | |||
There was a problem hiding this comment.
We should mention that our oAuth2.0 API intentionally does not implement the implicit request & resource owner password credential because of so and so reason.
Contributor
Author
There was a problem hiding this comment.
Done.
|
Morten Nielsen (@dotMorten), FYI, This PR removes implicit request as mentioned in the #4904 (comment) |
Ajit Surana (AjitSurana)
approved these changes
Dec 22, 2024
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Akanksha Patel (akanpatel2206)
enabled auto-merge (squash)
December 23, 2024 10:27
Akanksha Patel (akanpatel2206)
deleted the
user/akanpatel2206/OAuth2Manager_RemoveImplicit
branch
December 23, 2024 11:10
Mike Crider (codendone)
pushed a commit
that referenced
this pull request
Jan 10, 2025
* [OAuth2Manager] Remove APIs for Implicit grant type * Remove implicit refernces * Telemetry * Add security recommendations to OAuth2Manager spec.
This was referenced Dec 18, 2025
This was referenced Jan 14, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing APIs added for Implicit grant type suggested by security review.
Implicit grant type is not the recommended way to perform OAuth2.0. Authorization code grant type should be used.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.