[Build] Removed mrt.gdnsuppress and the reference to it - #4952
Merged
Merged
Conversation
alexlamtest
requested review from
Scott Jones (Scottj1s),
Mike Crider (codendone),
jamespik and
Kyaw Thant (kythant)
December 10, 2024 19:35
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scott Jones (Scottj1s)
approved these changes
Dec 10, 2024
alexlamtest
enabled auto-merge (squash)
December 10, 2024 20:02
Godly T.Alias (godlytalias)
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Update WindowsAppSDK-Build-Stage.yml * Delete dev/MRTCore/.gdn/mrt.gdnsuppress
Mike Crider (codendone)
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Update WindowsAppSDK-Build-Stage.yml * Delete dev/MRTCore/.gdn/mrt.gdnsuppress
This was referenced Dec 18, 2025
This was referenced Jan 14, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are now using the analyzeTargetGlob mechanism to skip BinSkim scanning of the Packages folder, so we no longer need the finer grain suppressions in mrt.gdnsuppress.
Hence, deleting mrt.gdnsuppress and removing the reference to it in the WindowsAppSDK-Build-Stage.yml file.
How verified:
///////////
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.