Update TeminalVelocity changes for OAuth2Manager Experimental API - #4912
Merged
Akanksha Patel (akanpatel2206) merged 1 commit intoNov 22, 2024
Merged
Conversation
Akanksha Patel (akanpatel2206)
requested review from
Ajit Surana (AjitSurana) and
Godly T.Alias (godlytalias)
November 22, 2024 10:03
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hemant Kumar (Hemantxk)
approved these changes
Nov 22, 2024
Saharsh Ananta Jaiswal (Saharsh979)
approved these changes
Nov 22, 2024
Godly T.Alias (godlytalias)
approved these changes
Nov 22, 2024
Akanksha Patel (akanpatel2206)
deleted the
user/akanpatel2206/WAB_velocity
branch
November 22, 2024 14:22
Mike Crider (codendone)
pushed a commit
that referenced
this pull request
Jan 10, 2025
This was referenced Dec 18, 2025
This was referenced Jan 14, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a TerminalVelocity check to control the availability of an experimental feature in the Windows App SDK. The feature is enabled in the Experimental channel, while it remains NOOP'd in the Preview and Stable channels, following the TerminalVelocity guidelines for efficient code stripping.
For more information:
https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/Experimental.md
https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/TerminalVelocity.md
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.