Skip to content

Interfaces for "Enhanced UX Notification for Video and Audio Call Feature" - #4783

Merged
satkh merged 16 commits into
mainfrom
user/satkh/vidCallFeature_1
Nov 22, 2024
Merged

Interfaces for "Enhanced UX Notification for Video and Audio Call Feature"#4783
satkh merged 16 commits into
mainfrom
user/satkh/vidCallFeature_1

Conversation

@satkh

@satkh satkh commented Oct 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

[Experimental]
This Pull Request adds required interfaces for "Video Or Audio calling" feature on App Notifications.

Feature proposal link : #4809

Spec link : #4824

anupriya13
Anupriya Verma (anupriya13) reviewed Oct 8, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotificationDevicesData.h Outdated
anupriya13
Anupriya Verma (anupriya13) reviewed Oct 8, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotifications.idl Outdated
anupriya13
Anupriya Verma (anupriya13) reviewed Oct 8, 2024
View reviewed changes
Comment thread test/AppNotificationTests/BaseTestSuite.cpp Outdated
anupriya13
Anupriya Verma (anupriya13) reviewed Oct 8, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotifications.idl Outdated
anupriya13
Anupriya Verma (anupriya13) reviewed Oct 8, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotifications.idl Outdated
anupriya13
Anupriya Verma (anupriya13) reviewed Oct 8, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotificationDevicesData.cpp Outdated
anupriya13
Anupriya Verma (anupriya13) reviewed Oct 8, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotificationDevicesData.h Outdated
danielayala94
Daniel Ayala (danielayala94) reviewed Oct 8, 2024
View reviewed changes
Comment thread dev/AppNotifications/NotificationDevicesData.cpp Outdated
@satkh

satkh commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

satkh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@satkh

satkh commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree [company="Microsoft"]

@satkh

satkh commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

codendone
Mike Crider (codendone) reviewed Oct 16, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotifications.idl Outdated
@anupriya13 Anupriya Verma (anupriya13) linked an issue Oct 17, 2024 that may be closed by this pull request
[Experimental] Adding interfaces for Feature "Enhanced UX Notification for Video and Audio Call" #4809
Closed
@anupriya13 Anupriya Verma (anupriya13) added area-Notifications Toast notification, badges, Live Tiles, push notifications api-design Updates to Project Reunion API surfaces feature proposal labels Oct 17, 2024
@anupriya13 Anupriya Verma (anupriya13) added this to the 1.7 milestone Oct 17, 2024
@jonwis

Jon Wiswall (jonwis) commented Oct 17, 2024

Copy link
Copy Markdown
Member

API design specs usually have clear "this is how an app would use it" samples. I see updates to tests, but not "Contoso wants to create a toast showing you this..."

@jonwis

Jon Wiswall (jonwis) commented Oct 17, 2024

Copy link
Copy Markdown
Member

OK, so this feature is about "before you answer the call, configure your local devices in this way"? So I can see what I'm going to look like before I answer the call?

Is there another API coming that lets the application provide a video feed of the incoming caller so you can see who you're going to connect with?

@satkh
satkh changed the base branch from release/1.7-stable to main November 19, 2024 06:03
@satkh

satkh commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Please fix the tooltip topic before you merge. The "be inert on unsupported" is optional to fix.

This "m_toolTip" is not added as part of this feature its existing.
I see those special characters (<,>,',") already escaped in the "set" method below.

image

codendone
Mike Crider (codendone) requested changes Nov 19, 2024
View reviewed changes
Comment thread dev/AppNotifications/AppNotifications.idl Outdated
Comment thread dev/AppNotifications/AppNotifications.idl Outdated
@satkh
satkh requested a review from SatwikKrSharma November 20, 2024 13:04
codendone
Mike Crider (codendone) approved these changes Nov 20, 2024
View reviewed changes

@codendone Mike Crider (codendone) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@satkh

satkh commented Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Nov 22, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@satkh

satkh commented Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Nov 22, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@satkh
satkh merged commit 5a41e3b into main Nov 22, 2024
@satkh
satkh deleted the user/satkh/vidCallFeature_1 branch November 22, 2024 14:24
@satkh
satkh restored the user/satkh/vidCallFeature_1 branch November 22, 2024 14:25
Mike Crider (codendone) pushed a commit that referenced this pull request Jan 10, 2025
@satkh
Interfaces for "Enhanced UX Notification for Video and Audio Call Fea…
a8a9da0 
…ture" (#4783)
@satkh satkh mentioned this pull request Mar 26, 2025
Merged
This was referenced Dec 18, 2025
Closed
Closed
Closed
This was referenced Jan 14, 2026
Closed
Merged
Closed
This was referenced Jan 26, 2026
Merged
Merged
This was referenced Feb 11, 2026
Closed
Open
@dependabot dependabot Bot mentioned this pull request Mar 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonwis Jon Wiswall (jonwis) jonwis approved these changes
@codendone Mike Crider (codendone) codendone approved these changes
@pmpurifoy Paul Purifoy (pmpurifoy) Awaiting requested review from pmpurifoy
@EricJohnson327 Eric Johnson (EricJohnson327) Awaiting requested review from EricJohnson327
@danielayala94 Daniel Ayala (danielayala94) Awaiting requested review from danielayala94
@vivekkhare31 Vivek Khare (vivekkhare31) Awaiting requested review from vivekkhare31
@JesseCol Jesse Collins (JesseCol) Awaiting requested review from JesseCol
@SatwikKrSharma SatwikKrSharma Awaiting requested review from SatwikKrSharma
+1 more reviewer
@anupriya13 Anupriya Verma (anupriya13) anupriya13 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-design Updates to Project Reunion API surfaces area-Notifications Toast notification, badges, Live Tiles, push notifications feature proposal needs-triage

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

[Experimental] Adding interfaces for Feature "Enhanced UX Notification for Video and Audio Call"

5 participants

@satkh @jonwis @anupriya13 @danielayala94 @codendone