Notifications assets full support

[Daniel Ayala (danielayala94)]

No description provided.

[Howard Kapustein (DrusTheAxe)]

Does WIL have registry functions?

[Pavan Hullumane (hulumane)]

I don't believe it does. But that would be very nice to have :)

[Rafael Rivera (riverar)]

I can't attach comments to unchanged lines so am putting it here instead.

---

WindowsAppSDK/dev/AppNotifications/AppNotificationUtility.cpp

Lines 75 to 81 in ce1563a

	GUID newNotificationGuid;
	THROW_IF_FAILED(CoCreateGuid(&newNotificationGuid));
	wil::unique_cotaskmem_string newNotificationGuidString;
	THROW_IF_FAILED(StringFromCLSID(newNotificationGuid, &newNotificationGuidString));
	RegisterValue(hKey, L"NotificationGUID", reinterpret_cast<const BYTE*>(newNotificationGuidString.get()), REG_SZ, wcslen(newNotificationGuidString.get()) * sizeof(wchar_t));
	return newNotificationGuidString.get();

This chunk of code generates a GUID with a known length then measures the length again, which isn't efficient. Instead you can perhaps do one of a few things (consult your nearest FTE for final guidance):

• Switch out the StringFromCLSID for StringFromGUID2, which returns the length
• Switch out the wcslen and use a WIL guid length constant (i.e. wil::guid_string_length)
• ...

---

WindowsAppSDK/dev/AppNotifications/AppNotificationUtility.cpp

Line 334 in ce1563a

displayName = wil::make_unique_string<wil::unique_cotaskmem_string>(SetDisplayNameBasedOnProcessName().c_str());

WindowsAppSDK/dev/AppNotifications/AppNotificationUtility.cpp

Lines 353 to 355 in ce1563a

	RegisterValue(hKey, L"DisplayName", reinterpret_cast<const BYTE*>(displayName.get()), REG_EXPAND_SZ, wcslen(displayName.get()) * sizeof(wchar_t));
	RegisterValue(hKey, L"IconUri", reinterpret_cast<const BYTE*>(iconFilePath.get()), REG_EXPAND_SZ, wcslen(iconFilePath.get()) * sizeof(wchar_t));
	RegisterValue(hKey, L"CustomActivator", reinterpret_cast<const BYTE*>(clsid.c_str()), REG_SZ, clsid.size() * sizeof(wchar_t));

SetDisplayNameBasedOnProcessName returns a std::wstring here (which tracks string length!), then we pull out a raw pointer, then measure the string length again. Maybe rejigger things a bit here?

[Pavan Hullumane (hulumane)]

Vaheeshta Mehrshahi (@vaheeshta) This is needed if we want apps to maintain their toast states even after a process name update later in the future. For example, if unpackaged app foo.exe has a name change to bar.exe in the future, this ensures that the apps toasts remain in the actioncentre. We should document.

[Pavan Hullumane (hulumane)]

It also is needed if apps change their path from c:\foo\name.exe to d:\bar\name.exe.

[Vaheeshta Mehrshahi (vaheeshta)]

Got it. I'll document this once I have the unpackaged sample code.

[Daniel Ayala (danielayala94)]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Daniel Ayala (danielayala94)]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

I have addressed all comments. Thank you for reviewing this PR! 😊

[Jon Wiswall (jonwis)]

(No change required)

I think this can be return wicFormatConverter.as<IWICBitmapSource>() ?

[Jon Wiswall (jonwis)]

Dead comment, please remove