Simplify Project Template: DpiAwareness in app.manifest - #1748
Merged
Merged
Conversation
ghost
added
the 
|
|
Marvin Rühe (Marv51)
changed the title
app.manifestapp.manifest
Rafael Rivera (riverar)
approved these changes
Nov 14, 2021
Contributor
Author
|
Can I do anything else to get this merged? Please take this into consideration. //cc: Andrew Leader (@andrewleader) |
Contributor
|
Evelyn Wu (@evelynwu-msft) would this be your area? Or who would own this? |
Member
No, I have no particular expertise to judge whether or not it is the correct thing to do (although it seems reasonable enough). MikeHillberg what are your thoughts on this? |
Contributor
Author
|
Hi MikeHillberg and Scott Jones (@Scottj1s)! What are your thoughts? |
Bob Pulliam (bpulliam)
approved these changes
Nov 1, 2022
Bob Pulliam (bpulliam)
pushed a commit
that referenced
this pull request
Feb 13, 2023
Bob Pulliam (bpulliam)
added a commit
that referenced
this pull request
Feb 14, 2023
* Remove UWP templates (#3148) * Remove UWP templates * Remove UWP Strings * Misc Fixes * TDBuild - updating localized resource files. * Add phone id to unblock store submission (#3206) * Remove copyright notice and license. Set xaml files to utf-8. (#3324) * simplify project template dpiAwareness in app.manifest (#1748) --------- Co-authored-by: TDBuild <DoNotEmailThis@dev.null.microsoft.com> Co-authored-by: Scott Jones <sjones@microsoft.com> Co-authored-by: Marvin Rühe <Marv51@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes microsoft/microsoft-ui-xaml#5659
Basically, the DPI awareness settings in the project template are needlessly complicated.
Those complicated settings are recommendable if old versions of Windows are supported, however WindowsAppSDK requires Windows 10 1809, which easily supports the most modern setting.