Win 101: Snowpal game - #30
Merged
Merged
Conversation
Jessica Dene Earley-Cha (chatasweetie)
requested review from
Michael Jolley (michaeljolley) and
Zach Teutsch (zateutsch)
February 19, 2025 20:01
added 4 commits
February 20, 2025 14:25
Michael Hawker (michael-hawker)
left a comment
Michael Hawker (michael-hawker)
left a comment
Contributor
There was a problem hiding this comment.
Initial batch of comments from the XAML side top-down. I think we may want to look at the game as a whole from the model side and what responsibilities lay where so we can better break things apart and not duplicate as much code.
Even though I think some of these suggestions will introduce a bit more complexity and concepts, I think we'd be able to cut our code down by 40-60% too.
added 2 commits
February 24, 2025 11:46
Jessica Dene Earley-Cha (chatasweetie)
force-pushed
the
snowpal-101
branch
from
March 4, 2025 22:46
2a04495 to
3a01593
Compare
added 4 commits
March 5, 2025 15:21
…ed unneeded call to start game from constructor
Contributor
|
As discussed, the other piece is just if we want to have the 3 layers vs. 2 for at least more introduction vs. the duplication of all the properties. |
…ctionary, update snow images, other minor changes
…les to align with best practices and uses light/dark mode
Jessica Dene Earley-Cha (chatasweetie)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the basic game for the student onboarding. This does not include the local llm portion yet nor any real styling/design yet.
PTAL to make sure that I'm on the right track