Provide User-Friendly Message for Extended Unicode Escapes in Regular Expressions in Non-Unicode Modes#58981
Merged
rbuckton merged 5 commits intomicrosoft:mainfrom Jul 18, 2024
Conversation
… Expressions in Non-Unicode Modes
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
DanielRosenwasser
approved these changes
Jun 29, 2024
rbuckton
suggested changes
Jul 17, 2024
graphemecluster
force-pushed
the
regex-extended-escape
branch
from
bffa7ce to
115f5eb
Compare
rbuckton
approved these changes
Jul 17, 2024
Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
Contributor
Author
|
I’ve reordered the commits and let the checks perform both before and after your suggested change to ensure everything works as expected. |
rbuckton
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the error message of
/\u{10000}/fromHexadecimal digit expected.toUnicode escape sequences are only available when the Unicode (u) flag or the Unicode Sets (v) flag is set.(message analogous to TS1530), as @k1tikurisu pointed out in his article [in Japanese] that it’s hard to understand the intention of the message.