Make sure that jsdoc is always in range with parameter declaration#58538
Make sure that jsdoc is always in range with parameter declaration#58538sheetalkamat merged 1 commit intomainfrom
Conversation
weswigham
left a comment
There was a problem hiding this comment.
Funky. I'm not sure why we even parse a comment range on the incremental reparse in this case, since we deleted the leading /. The comment range scanner function pretty clearly only matches comments on seeing a // or /* sequence. The single / left after the edit should be interpreted as a division operator or opening to a regex literal, I'd think. I get that the jsdoc nodes we make from these spans, and adjusting them in the incremental parser, is ultimately what triggers the assertion (which is why excluding them fixes it), just feels weird that we have a jsdoc node at all after the edit - I'd assume we'd have rescanned from in front of the jsdoc host node and thrown it out.
|
I guess I would have thought this were a bug somewhere in |
|
The issue was that when first source File was created with |
Fixes #56677