Print baseline diffs on test failures#57852
Merged
jakebailey merged 4 commits intomicrosoft:mainfrom Mar 19, 2024
Merged
Conversation
iisaduan
approved these changes
Mar 19, 2024
Member
Author
|
Will make a bad change quick and then revert it to see that this works. |
Member
Author
|
Oh yeah this PR is wrong. Will fix |
This reverts commit 9dce39e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just on Windows/Node14, we're seeing this test flake:
I'm not sure we can figure this out locally, but we can at least print out the baseline diff when tests fail.