isolatedModules error on global shadowed by imported type by frigus02 · Pull Request #56732 · microsoft/TypeScript

frigus02 · 2023-12-11T10:31:55Z

Fixes #56521

I took inspiration from #56354, which seems very similar.

andrewbranch

Thanks! I think this is pretty close.

src/compiler/checker.ts

frigus02 · 2023-12-12T10:05:04Z

Thanks for the quick review! I think I addressed your comments.

(Not sure about the comment resolving etiquette here. I hope me resolving them is fine?)

frigus02 · 2023-12-12T15:56:52Z

The new error currently incorrectly fires for the following Node.js code:

import { Console } from "node:console";
const c: Console = new Console();

That's because console.Console is indeed a global. But it's re-exported in the module node:console. Importantly, though, the global is console.Console, not Console, so the import is necessary.

Node.js typings for reference: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/420d2ceb50f728aa715da1250a2a9f27760a640c/types/node/console.d.ts#L412

Weirdly there is no error for this code:

import { Console } from "node:console";
new Console();

I'm going to look into that tomorrow. If you have any ideas, I'd definitely appreciate your help, @andrewbranch.

frigus02 · 2023-12-12T16:47:23Z

Aha. I think SymbolFlags.Value is not a single bit. I just copied the check from a few lines up. But I think I need to use (meaning & SymbolFlags.Value) === SymbolFlags.Value here. I'll test some more tomorrow and update the code and tests.

andrewbranch · 2023-12-12T17:38:07Z

Oh, good catch. Yeah, I think something like that should work, or alternatively a lookup with SymbolFlags.Type | SymbolFlags.NamespaceModule

frigus02 · 2023-12-13T10:35:43Z

As far as I can tell this looks good now. I did not use SymbolFlags.Type | SymbolFlags.NamespaceModule, yet. But happy to switch to that if you prefer.

andrewbranch · 2023-12-13T16:41:15Z

@typescript-bot perf test this
@typescript-bot test top200

typescript-bot · 2023-12-13T16:41:18Z

Heya @andrewbranch, I've started to run the regular perf test suite on this PR at fa03480. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-13T16:41:18Z

Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at fa03480. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-13T17:01:56Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,410k (± 0.01%)}	_{295,395k (± 0.01%)}	_~	_295,380k	_295,420k	_{p=0.261 n=6}
_{Parse Time}	_{2.64s (± 0.46%)}	_{2.64s (± 0.41%)}	_~	_2.62s	_2.65s	_{p=0.432 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.50%)}	_~	_0.82s	_0.83s	_{p=0.405 n=6}
_{Check Time}	_{8.14s (± 0.39%)}	_{8.14s (± 0.29%)}	_~	_8.11s	_8.18s	_{p=0.936 n=6}
_{Emit Time}	_{7.08s (± 0.15%)}	_{7.08s (± 0.36%)}	_~	_7.05s	_7.12s	_{p=0.745 n=6}
_{Total Time}	_{18.69s (± 0.18%)}	_{18.69s (± 0.25%)}	_~	_18.61s	_18.75s	_{p=0.936 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{195,329k (± 1.54%)}	_{194,823k (± 1.49%)}	_~	_191,383k	_197,488k	_{p=1.000 n=6}
_{Parse Time}	_{1.35s (± 1.21%)}	_{1.36s (± 1.08%)}	_~	_1.34s	_1.38s	_{p=0.677 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.26s (± 0.44%)}	_{9.26s (± 0.35%)}	_~	_9.20s	_9.29s	_{p=1.000 n=6}
_{Emit Time}	_{2.63s (± 0.46%)}	_{2.64s (± 0.65%)}	_~	_2.62s	_2.67s	_{p=0.154 n=6}
_{Total Time}	_{13.96s (± 0.38%)}	_{13.97s (± 0.34%)}	_~	_13.89s	_14.02s	_{p=0.747 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,379k (± 0.01%)}	_{347,356k (± 0.01%)}	_~	_347,333k	_347,386k	_{p=0.078 n=6}
_{Parse Time}	_{2.45s (± 0.40%)}	_{2.45s (± 0.40%)}	_~	_2.44s	_2.47s	_{p=1.000 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.92s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.311 n=6}
_{Check Time}	_{6.90s (± 0.20%)}	_{6.89s (± 0.31%)}	_~	_6.87s	_6.92s	_{p=0.566 n=6}
_{Emit Time}	_{4.05s (± 0.48%)}	_{4.05s (± 0.44%)}	_~	_4.02s	_4.07s	_{p=0.808 n=6}
_{Total Time}	_{14.32s (± 0.22%)}	_{14.32s (± 0.24%)}	_~	_14.29s	_14.37s	_{p=0.936 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,640k (± 0.00%)}	_{302,650k (± 0.00%)}	_~	_302,640k	_302,661k	_{p=0.230 n=6}
_{Parse Time}	_{2.00s (± 0.74%)}	_{1.99s (± 0.49%)}	_~	_1.98s	_2.01s	_{p=0.440 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.01s (± 1.25%)}	_~	_0.99s	_1.02s	_{p=0.270 n=6}
_{Check Time}	_{6.28s (± 0.29%)}	_{6.27s (± 0.46%)}	_~	_6.23s	_6.30s	_{p=0.746 n=6}
_{Emit Time}	_{3.59s (± 0.89%)}	_{3.59s (± 0.66%)}	_~	_3.56s	_3.63s	_{p=0.683 n=6}
_{Total Time}	_{12.86s (± 0.31%)}	_{12.86s (± 0.13%)}	_~	_12.84s	_12.88s	_{p=0.687 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,788k (± 0.00%)}	_{506,806k (± 0.01%)}	_~	_506,751k	_506,841k	_{p=0.173 n=6}
_{Parse Time}	_{2.58s (± 0.47%)}	_{2.58s (± 0.67%)}	_~	_2.56s	_2.61s	_{p=0.558 n=6}
_{Bind Time}	_{0.99s (± 1.28%)}	_{0.98s (± 0.77%)}	_~	_0.97s	_0.99s	_{p=0.301 n=6}
_{Check Time}	_{16.87s (± 0.37%)}	_{16.90s (± 0.39%)}	_~	_16.83s	_17.00s	_{p=0.518 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.43s (± 0.27%)}	_{20.46s (± 0.36%)}	_~	_20.40s	_20.59s	_{p=0.520 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,813k (± 0.01%)}	_{512,847k (± 0.01%)}	_~	_512,780k	_512,933k	_{p=0.471 n=6}
_{Parse Time}	_{3.27s (± 0.19%)}	_{3.27s (± 0.19%)}	_~	_3.26s	_3.28s	_{p=1.000 n=6}
_{Bind Time}	_{1.54s (± 0.36%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=0.137 n=6}
_{Check Time}	_{2.81s (± 0.43%)}	_{2.82s (± 0.73%)}	_~	_2.80s	_2.86s	_{p=0.367 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 5.69%)}	_~	_0.07s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.69s (± 0.19%)}	_{7.71s (± 0.26%)}	_~	_7.69s	_7.74s	_{p=0.252 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,340ms (± 0.36%)}	_{2,338ms (± 0.45%)}	_~	_2,327ms	_2,352ms	_{p=0.687 n=6}
_{Req 2 - geterr}	_{5,414ms (± 1.22%)}	_{5,457ms (± 1.58%)}	_~	_5,359ms	_5,551ms	_{p=0.199 n=6}
_{Req 3 - references}	_{323ms (± 0.34%)}	_{324ms (± 0.87%)}	_~	_320ms	_326ms	_{p=0.516 n=6}
_{Req 4 - navto}	_{278ms (± 1.27%)}	_{277ms (± 1.39%)}	_~	_273ms	_280ms	_{p=0.337 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 6.36%)}	_{87ms (± 5.86%)}	_~	_82ms	_92ms	_{p=0.738 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,487ms (± 0.64%)}	_{2,482ms (± 1.35%)}	_~	_2,435ms	_2,533ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,086ms (± 1.54%)}	_{4,096ms (± 1.46%)}	_~	_4,048ms	_4,215ms	_{p=0.376 n=6}
_{Req 3 - references}	_{344ms (± 1.16%)}	_{341ms (± 1.40%)}	_~	_337ms	_348ms	_{p=0.627 n=6}
_{Req 4 - navto}	_{285ms (± 0.26%)}	_{285ms (± 0.29%)}	_~	_284ms	_286ms	_{p=0.306 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 5.20%)}	_{87ms (± 5.73%)}	_~	_77ms	_90ms	_{p=0.607 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,593ms (± 0.72%)}	_{2,600ms (± 0.85%)}	_~	_2,571ms	_2,632ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{1,698ms (± 1.88%)}	_{1,699ms (± 1.33%)}	_~	_1,672ms	_1,729ms	_{p=1.000 n=6}
_{Req 3 - references}	_{112ms (± 9.92%)}	_{122ms (± 2.29%)}	_~	_117ms	_125ms	_{p=0.060 n=6}
_{Req 4 - navto}	_{365ms (± 0.56%)}	_{366ms (± 0.21%)}	_~	_365ms	_367ms	_{p=0.319 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{307ms (± 2.21%)}	_{306ms (± 2.16%)}	_~	_295ms	_314ms	_{p=0.872 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.78ms (± 0.20%)}	_{152.73ms (± 0.18%)}	_~	_151.66ms	_157.07ms	_{p=0.304 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.54ms (± 0.19%)}	_{228.35ms (± 0.17%)}	_{-0.19ms (- 0.08%)}	_227.09ms	_235.35ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.62ms (± 0.20%)}	_{229.64ms (± 0.20%)}	_~	_227.79ms	_236.45ms	_{p=1.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.48ms (± 0.19%)}	_{229.35ms (± 0.16%)}	_{-0.12ms (- 0.05%)}	_228.07ms	_232.75ms	_{p=0.020 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-12-13T18:17:10Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/56732/merge:

Everything looks good!

andrewbranch

Thanks @frigus02!

…56732)

isolatedModules error on global shadowed by imported type

006cb6a

typescript-bot assigned andrewbranch Dec 11, 2023

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 11, 2023

andrewbranch requested changes Dec 11, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

look for local ~Value instead of Type symbol

dd563e8

add test for and fix nodejs example

fa03480

andrewbranch approved these changes Dec 13, 2023

View reviewed changes

andrewbranch merged commit ba9eddb into microsoft:main Dec 13, 2023

frigus02 deleted the shadow-type branch December 13, 2023 18:35

c0sta pushed a commit to c0sta/TypeScript that referenced this pull request Dec 20, 2023

isolatedModules error on global shadowed by imported type (microsoft#…

ed79345

…56732)

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

frigus02 commented Dec 11, 2023

Uh oh!

andrewbranch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

frigus02 commented Dec 12, 2023

Uh oh!

frigus02 commented Dec 12, 2023

Uh oh!

frigus02 commented Dec 12, 2023

Uh oh!

andrewbranch commented Dec 12, 2023

Uh oh!

frigus02 commented Dec 13, 2023

Uh oh!

andrewbranch commented Dec 13, 2023

Uh oh!

typescript-bot commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 13, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Dec 13, 2023

Uh oh!

andrewbranch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Dec 13, 2023 •

edited

Loading

typescript-bot commented Dec 13, 2023 •

edited

Loading