Add GHA workflow that auto LKGs on pushes to release branches#56453
Closed
jakebailey wants to merge 6 commits intomicrosoft:mainfrom
Closed
Add GHA workflow that auto LKGs on pushes to release branches#56453jakebailey wants to merge 6 commits intomicrosoft:mainfrom
jakebailey wants to merge 6 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
Member
Author
|
Took #57835 instead for now. |
jakebailey
commented
Mar 18, 2024
Comment on lines
+5
to
+8
| branches: | ||
| - 'release-*' | ||
| branches-ignore: | ||
| - 'release-[0-4].*' # Predates hereby |
Member
Author
There was a problem hiding this comment.
Apparently you can't have both of these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates a manual step when cherry picking changes.
Ironically, I think this PR would need to be cherry-picked to the latest release branch to actually work.
I have left the other LKG pushing from other workflows in place, but I can make those only commit partial state instead... it's just tricky because we have things like version strings that get updated and whatnot.