Revert "Disallow numeric literals with negative numbers (#55268)"#56422
Merged
jakebailey merged 2 commits intomicrosoft:mainfrom Nov 15, 2023
Merged
Revert "Disallow numeric literals with negative numbers (#55268)"#56422jakebailey merged 2 commits intomicrosoft:mainfrom
jakebailey merged 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
approved these changes
Nov 15, 2023
Member
Author
|
@typescript-bot cherry-pick this to release-5.3 |
Collaborator
|
Heya @jakebailey, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @jakebailey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually. |
Member
Author
|
sigh |
Member
Author
|
@typescript-bot cherry-pick this to release-5.3 |
Collaborator
|
Heya @jakebailey, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @jakebailey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Nov 16, 2023
DanielRosenwasser
pushed a commit
that referenced
this pull request
Nov 16, 2023
Andarist
added a commit
to Andarist/TypeScript
that referenced
this pull request
Nov 28, 2023
…osoft#55268)" (microsoft#56422)" This reverts commit 3333e90.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #55268.
Closes #56301
Updates #56272
For 5.3 it seemed too risky to take this change; there's a lot more inconsistency we've discovered at the last minute and changing it again later seemed bad.
Also #56270 shows that this behavior was being depended on as TS lacks true infinity types.