Narrow down non-const enity name expressions within element access expressions by Andarist · Pull Request #56392 · microsoft/TypeScript

Andarist · 2023-11-14T09:16:55Z

an experiment to fix #51368 . I wonder what the perf tests show for this (cc @jakebailey ) 😉

…pressions

jakebailey · 2023-11-14T12:27:28Z

Fails the self check so I'm going to assume that it'll break in testing; can run once you've had a chance to look.

fatcerberus · 2023-11-14T14:25:30Z

To be clear, this isn't a general fix for #56389, correct?

Andarist · 2023-11-14T15:10:04Z

Yeah, it isn't. I specifically only looked into what @DetachHead mentioned here

…-entity-name-expressions-in-element-accesses

Andarist · 2023-12-28T23:00:28Z

@jakebailey I fixed the self-check here. Would you mind running the perf suite? :)

Andarist · 2023-12-28T23:01:43Z

src/compiler/checker.ts

+                if (rootDeclaration.kind !== SyntaxKind.VariableDeclaration) {
+                    return true;
+                }


TODO: recheck correctness here

jakebailey · 2024-01-04T19:23:33Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2024-01-04T19:23:36Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 5d49f98. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T19:23:36Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 5d49f98. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T19:23:36Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 5d49f98. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T19:23:36Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 5d49f98. You can monitor the build here.

typescript-bot · 2024-01-04T19:23:36Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 5d49f98. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-04T19:43:26Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159261/artifacts?artifactName=tgz&fileId=A10C51230D65ED8DD9ABAA7E144F16A014B03A2C082E67DD7993C0F756E4E4C402&fileName=/typescript-5.4.0-insiders.20240104.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56392-10".;

typescript-bot · 2024-01-04T20:17:05Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56392/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-01-04T20:27:07Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,439k (± 0.01%)}	_{295,546k (± 0.01%)}	_{+107k (+ 0.04%)}	_295,498k	_295,572k	_{p=0.008 n=6}
_{Parse Time}	_{2.65s (± 0.21%)}	_{2.65s (± 0.19%)}	_~	_2.64s	_2.65s	_{p=0.640 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.50%)}	_~	_0.82s	_0.83s	_{p=0.405 n=6}
_{Check Time}	_{8.14s (± 0.08%)}	_{8.16s (± 0.41%)}	_~	_8.11s	_8.21s	_{p=0.097 n=6}
_{Emit Time}	_{7.10s (± 0.43%)}	_{7.10s (± 0.23%)}	_~	_7.08s	_7.12s	_{p=0.745 n=6}
_{Total Time}	_{18.71s (± 0.16%)}	_{18.73s (± 0.23%)}	_~	_18.66s	_18.78s	_{p=0.296 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,464k (± 1.56%)}	_{192,547k (± 1.22%)}	_~	_191,548k	_197,344k	_{p=0.378 n=6}
_{Parse Time}	_{1.35s (± 1.62%)}	_{1.35s (± 1.96%)}	_~	_1.30s	_1.38s	_{p=0.732 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.27s (± 0.33%)}	_{9.26s (± 0.46%)}	_~	_9.19s	_9.30s	_{p=0.870 n=6}
_{Emit Time}	_{2.61s (± 0.29%)}	_{2.62s (± 0.62%)}	_~	_2.60s	_2.64s	_{p=0.454 n=6}
_{Total Time}	_{13.95s (± 0.23%)}	_{13.94s (± 0.36%)}	_~	_13.85s	_13.99s	_{p=0.747 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,413k (± 0.00%)}	_{347,471k (± 0.01%)}	_{+58k (+ 0.02%)}	_347,432k	_347,505k	_{p=0.005 n=6}
_{Parse Time}	_{2.46s (± 0.36%)}	_{2.46s (± 0.79%)}	_~	_2.43s	_2.49s	_{p=0.801 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.88s (± 0.33%)}	_{6.96s (± 0.36%)}	_{+0.08s (+ 1.21%)}	_6.93s	_6.99s	_{p=0.005 n=6}
_{Emit Time}	_{4.07s (± 0.50%)}	_{4.05s (± 0.63%)}	_~	_4.02s	_4.08s	_{p=0.222 n=6}
_{Total Time}	_{14.33s (± 0.28%)}	_{14.40s (± 0.38%)}	_{+0.07s (+ 0.49%)}	_14.34s	_14.49s	_{p=0.043 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,726k (± 0.00%)}	_{302,868k (± 0.01%)}	_{+142k (+ 0.05%)}	_302,852k	_302,895k	_{p=0.005 n=6}
_{Parse Time}	_{1.99s (± 0.45%)}	_{1.99s (± 0.82%)}	_~	_1.98s	_2.02s	_{p=0.803 n=6}
_{Bind Time}	_{1.01s (± 1.22%)}	_{1.00s (± 1.22%)}	_~	_0.99s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{6.29s (± 0.31%)}	_{6.39s (± 0.39%)}	_{+0.11s (+ 1.67%)}	_6.36s	_6.42s	_{p=0.005 n=6}
_{Emit Time}	_{3.58s (± 0.56%)}	_{3.57s (± 0.39%)}	_~	_3.56s	_3.59s	_{p=0.744 n=6}
_{Total Time}	_{12.87s (± 0.28%)}	_{12.97s (± 0.29%)}	_{+0.10s (+ 0.80%)}	_12.91s	_13.02s	_{p=0.006 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,808k (± 0.01%)}	_{506,828k (± 0.01%)}	_~	_506,795k	_506,868k	_{p=0.230 n=6}
_{Parse Time}	_{2.58s (± 0.53%)}	_{2.58s (± 0.47%)}	_~	_2.57s	_2.60s	_{p=0.410 n=6}
_{Bind Time}	_{0.99s (± 0.52%)}	_{0.99s (± 0.82%)}	_~	_0.98s	_1.00s	_{p=0.140 n=6}
_{Check Time}	_{16.91s (± 0.37%)}	_{16.96s (± 0.14%)}	_~	_16.93s	_16.99s	_{p=0.090 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.48s (± 0.32%)}	_{20.54s (± 0.13%)}	_~	_20.50s	_20.58s	_{p=0.078 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,914k (± 0.01%)}	_{512,850k (± 0.01%)}	_~	_512,773k	_512,906k	_{p=0.066 n=6}
_{Parse Time}	_{3.28s (± 0.31%)}	_{3.27s (± 0.27%)}	_~	_3.26s	_3.28s	_{p=0.273 n=6}
_{Bind Time}	_{1.54s (± 0.36%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=0.137 n=6}
_{Check Time}	_{2.83s (± 0.73%)}	_{2.81s (± 0.49%)}	_~	_2.79s	_2.82s	_{p=0.052 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=1.000 n=6}
_{Total Time}	_{7.71s (± 0.35%)}	_{7.68s (± 0.27%)}	_~	_7.66s	_7.71s	_{p=0.064 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,344ms (± 0.83%)}	_{2,353ms (± 0.63%)}	_~	_2,334ms	_2,371ms	_{p=0.296 n=6}
_{Req 2 - geterr}	_{5,405ms (± 1.15%)}	_{5,466ms (± 1.34%)}	_{+61ms (+ 1.13%)}	_5,400ms	_5,572ms	_{p=0.045 n=6}
_{Req 3 - references}	_{324ms (± 0.42%)}	_{324ms (± 0.74%)}	_~	_321ms	_328ms	_{p=0.806 n=6}
_{Req 4 - navto}	_{276ms (± 1.16%)}	_{274ms (± 0.95%)}	_~	_270ms	_277ms	_{p=0.287 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{89ms (± 6.71%)}	_{92ms (± 4.76%)}	_~	_84ms	_95ms	_{p=0.413 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,470ms (± 0.92%)}	_{2,490ms (± 1.33%)}	_~	_2,455ms	_2,532ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{4,180ms (± 1.98%)}	_{4,097ms (± 1.67%)}	_~	_4,056ms	_4,235ms	_{p=0.149 n=6}
_{Req 3 - references}	_{336ms (± 1.34%)}	_{339ms (± 1.28%)}	_~	_333ms	_343ms	_{p=0.420 n=6}
_{Req 4 - navto}	_{285ms (± 1.27%)}	_{286ms (± 1.02%)}	_~	_284ms	_292ms	_{p=0.216 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 6.55%)}	_{90ms (± 1.37%)}	_{🔻+6ms (+ 7.62%)}	_87ms	_90ms	_{p=0.026 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,600ms (± 0.57%)}	_{2,613ms (± 0.35%)}	_~	_2,601ms	_2,621ms	_{p=0.172 n=6}
_{Req 2 - geterr}	_{1,729ms (± 2.74%)}	_{1,741ms (± 1.57%)}	_~	_1,703ms	_1,769ms	_{p=0.873 n=6}
_{Req 3 - references}	_{116ms (± 8.61%)}	_{112ms (±10.30%)}	_~	_100ms	_123ms	_{p=0.462 n=6}
_{Req 4 - navto}	_{365ms (± 0.27%)}	_{368ms (± 1.42%)}	_~	_364ms	_378ms	_{p=0.203 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{309ms (± 1.70%)}	_{310ms (± 0.80%)}	_~	_307ms	_313ms	_{p=0.685 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.63ms (± 0.20%)}	_{153.57ms (± 0.20%)}	_~	_152.55ms	_157.42ms	_{p=0.087 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.14ms (± 0.15%)}	_{228.88ms (± 0.16%)}	_{-0.26ms (- 0.11%)}	_227.60ms	_234.31ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.28ms (± 0.20%)}	_{230.30ms (± 0.19%)}	_~	_228.60ms	_233.66ms	_{p=0.784 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.60ms (± 0.21%)}	_{230.72ms (± 0.20%)}	_{+0.12ms (+ 0.05%)}	_229.04ms	_237.79ms	_{p=0.003 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-01-04T20:31:34Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-01-04T21:53:12Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56392/merge:

Everything looks good!

Andarist · 2024-03-19T16:48:25Z

superseded by #57847

Narrow down non-const enity name expressions within element access ex…

5511b1b

…pressions

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 14, 2023

sandersn added the Experiment A fork with an experimental idea which might not make it into master label Nov 29, 2023

Andarist marked this pull request as draft December 26, 2023 17:48

Andarist added 2 commits December 28, 2023 21:28

Merge remote-tracking branch 'origin/main' into narrow-down-non-const…

8030e75

…-entity-name-expressions-in-element-accesses

Fixed self-check crash

5d49f98

Andarist marked this pull request as ready for review December 28, 2023 22:59

Andarist commented Dec 28, 2023

View reviewed changes

Andarist mentioned this pull request Dec 28, 2023

Add an extra test case related to control flow of element access using non-const variable #56893

Merged

Andarist closed this Mar 19, 2024

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

Andarist commented Nov 14, 2023

Uh oh!

jakebailey commented Nov 14, 2023

Uh oh!

fatcerberus commented Nov 14, 2023

Uh oh!

Andarist commented Nov 14, 2023

Uh oh!

Andarist commented Dec 28, 2023

Uh oh!

Andarist Dec 28, 2023

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Jan 4, 2024

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 4, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

typescript-bot commented Jan 4, 2024

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Jan 4, 2024

Uh oh!

typescript-bot commented Jan 4, 2024

Uh oh!

Andarist commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading

typescript-bot commented Jan 4, 2024 •

edited

Loading