Remove lib.d.ts line info in inlay hint baselines#55426
Merged
MariaSolOs merged 1 commit intomicrosoft:mainfrom Aug 22, 2023
Merged
Remove lib.d.ts line info in inlay hint baselines#55426MariaSolOs merged 1 commit intomicrosoft:mainfrom
MariaSolOs merged 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Member
|
No test change; is this because your other PR is what introduces them? Was hoping to see an example that shows it working but otherwise it's probably fine. |
jakebailey
reviewed
Aug 21, 2023
| if (hint.displayParts) { | ||
| hint.displayParts = ts.map(hint.displayParts, part => { | ||
| if (part.file && /lib(?:.*)\.d\.ts$/.test(part.file)) { | ||
| part.span!.start = -1; |
Contributor
Author
There was a problem hiding this comment.
Yes. If the file is defined, the span definitely is.
Contributor
Author
Yep. My type hints PR will have the changes. I already tried cherry picking this locally and it worked. |
jakebailey
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some issues in #55141 because of including line information from
lib.d.tsfiles, so this PR attempts to make those baselines more robust.